-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.6.0 #631
v1.6.0 #631
Conversation
they are not being used in before change detection
Update to Angular 8
[Feature] Go-Tree
[Chore] ng-select upgrade for Angular v8 compatability
[Chore] Update and Simplify PR Template
[Bug] Align Form Heights
Adds copy permalink buttons to all card headers in the style-guide
[Feature] Table Title Template
[Feature] Select Typeahead Search Text
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]>
[Chore] File Upload Enhancements
[Chore] Correct Light Bg Color Variables
Bump lodash from 4.17.15 to 4.17.19
[Chore] Virtual Scroll Docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see an update to the package.json goponents version in here. Should we bump that up to 1.6.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice one little thing I forgot to change for the go-copy animation tests. Might not be worth changing.
🥇
projects/go-lib/src/lib/components/go-copy/go-copy.component.spec.ts
Outdated
Show resolved
Hide resolved
[Chore] go-copy Test Typo
[Chore] v1.6.0 Docs Update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
For some reason Travis is not reporting builds right now. I can confirm the build is successful and we're good to merge this. |
Change log for
v1.6.0
Complete Refactor of
GoConfigService
The reasons for this are:
This approach is a much simpler implementation for branding and other configurations within applications. Most of these will not effect implementations.
Changes Required
toggleHeaderBrandingEnabled
method was used to instead use the newsetConfig
method<go-header>
is used, remove any of these bindings (altText
,logo
,logoLink
, andlogoLinkUseRouterLink
). Then when the initial configuration is set, these bindings can be set through using thesetConfig
method. (This will be done in the component where thego-layout
component resides)brandFontColor
headerBrandingEnabled
property tobrandingMode
. This may not need to be done if the new "client" branding mode is not implementedoverrideMenuColor
It is strongly recommended to read the new documentation around this service for full understanding of how it works now. Also, for further reference or troubleshooting the PR could be helpful.
🚢 New Features
Action Sheet
go-panel
- Add ability to use content-projection within go-panels #619Config Service
setConfig
getConfig
setLogo
setBrandingMode
Copy Card Link
File Upload
Select
optgroup
- Go select optgroup custom template #621Side Nav
target
s for external links - [Chore] Sidenav External Target #622Table
Tree
Utilities
colors.util.ts
file - [Chore] Refactor Branding Config #596RGB
interfacecontrastIsAccessible
methodshadeHex
methodshadeRGB
methodrgbToHex
methodhexToRgb
methodluminance
methodcalculateContrast
methodVirtual Scroll
🐞 Bug Fixes
Form Elements
File Upload
Select
title
attribute on the label template would not appear - [Bug] Label Title Hover Select #623✏️ General & Design
Angular 8
This version of Goponents introduces support for Angular version 8, this also means we're upgrading the
ng-select
peer dependency for thego-select
. Related PR's: #590, #597Style Guide
Added links to every card example in the documentation, for easy reference - #601
Misc
go-copy
- Add user-feedback to go-copy #620go-action-sheet
styles - Update action sheet styles #625go-datepicker
styles - [Chore] Datepicker Design Updates #609go-select
options styles - [Chore] Select Options Styles Update #606go-side-nav
styles - Side Nav Style Updates #617