Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.0 #631

Merged
merged 73 commits into from
Jul 24, 2020
Merged

v1.6.0 #631

merged 73 commits into from
Jul 24, 2020

Conversation

grahamhency
Copy link
Contributor

@grahamhency grahamhency commented Jul 23, 2020

Change log for v1.6.0

⚠️ Breaking Changes

Complete Refactor of GoConfigService

  • GoConfigService
    • Removed the toggleHeaderBrandingEnabled method in favor of setConfig
    • Removed the overrideMenuColor method
    • Moved the contrastIsAccessible method to the new colors.util.ts file
    • Moved the RGB interface to the new colors.util.ts file
  • GoHeader Component
    • Removed bindings for altText, logo, logoLink, and logoLinkUseRouterLink in favor of setting them in the setConfig method on the GoConfigService
  • GoConfigInterface
    • Removed the brandFontColor property as it is no longer necessary
    • Removed the headerBrandingEnabled property as it has been replaced by the brandingMode property
The reasons for this are:

This approach is a much simpler implementation for branding and other configurations within applications. Most of these will not effect implementations.

Changes Required
  1. Change anywhere that toggleHeaderBrandingEnabled method was used to instead use the new setConfig method
  2. Where <go-header> is used, remove any of these bindings (altText, logo, logoLink, and logoLinkUseRouterLink). Then when the initial configuration is set, these bindings can be set through using the setConfig method. (This will be done in the component where the go-layout component resides)
  3. Remove any reference to brandFontColor
  4. Change headerBrandingEnabled property to brandingMode. This may not need to be done if the new "client" branding mode is not implemented
  5. Remove any reference to overrideMenuColor

It is strongly recommended to read the new documentation around this service for full understanding of how it works now. Also, for further reference or troubleshooting the PR could be helpful.


🚢 New Features

Action Sheet

Config Service

  • Added multiple features and methods - [Chore] Refactor Branding Config #596
    • Added ability to specify a secondary logo
    • Added the ability to setConfig
    • Added the ability to getConfig
    • Added the ability to setLogo
    • Added the ability to setBrandingMode

Copy Card Link

File Upload

Select

Side Nav

Table

Tree

Utilities

  • Added a new colors.util.ts file - [Chore] Refactor Branding Config #596
    • RGB interface
    • contrastIsAccessible method
    • shadeHex method
    • shadeRGB method
    • rgbToHex method
    • hexToRgb method
    • luminance method
    • calculateContrast method

Virtual Scroll

🐞 Bug Fixes

Form Elements

File Upload

Select

✏️ General & Design

Angular 8

This version of Goponents introduces support for Angular version 8, this also means we're upgrading the ng-select peer dependency for the go-select. Related PR's: #590, #597

Style Guide

Added links to every card example in the documentation, for easy reference - #601

Misc

patrick-lewandowski and others added 30 commits January 23, 2020 14:02
they are not being used in before change detection
[Chore] ng-select upgrade for Angular v8 compatability
[Chore] Update and Simplify PR Template
Adds copy permalink buttons to all card headers in the style-guide
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an update to the package.json goponents version in here. Should we bump that up to 1.6.0?

projects/go-lib/package.json Outdated Show resolved Hide resolved
jaredami
jaredami previously approved these changes Jul 24, 2020
Copy link
Contributor

@jaredami jaredami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice one little thing I forgot to change for the go-copy animation tests. Might not be worth changing.

🥇

@grahamhency grahamhency requested a review from StevenUlmer July 24, 2020 15:24
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@grahamhency
Copy link
Contributor Author

For some reason Travis is not reporting builds right now. I can confirm the build is successful and we're good to merge this.

@grahamhency grahamhency merged commit 4d593ef into master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants