Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use content-projection within go-panels #619

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Add ability to use content-projection within go-panels #619

merged 2 commits into from
Jul 14, 2020

Conversation

jaredami
Copy link
Contributor

@jaredami jaredami commented Jul 9, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

Resolves #618

What is the new behavior?

This enables html content to be projected into a go-panel, thus enabling styling to be applied to panel content.

Does this PR introduce a breaking change?

  • Yes
  • No

@jaredami jaredami added the feature New feature request label Jul 9, 2020
@jaredami jaredami requested a review from grahamhency July 9, 2020 17:03
@jaredami jaredami mentioned this pull request Jul 14, 2020
Merged
14 tasks
grahamhency
grahamhency approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, 👍

@jaredami jaredami merged commit 09ea05c into dev Jul 14, 2020
@jaredami jaredami deleted the go_panel_content_projection branch July 14, 2020 19:54
@grahamhency grahamhency mentioned this pull request Jul 23, 2020
Merged
@jaredami jaredami mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamhency grahamhency grahamhency approved these changes

Assignees

@grahamhency grahamhency

Labels
feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add ability to use content-projection within go-panels
2 participants
@jaredami @grahamhency