Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: give pr permission for reviewdog #862

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Dec 18, 2024

Resolve #861

  • Run linter the PR is against master branch
  • Run linter when pull-request triggered
  • Allow review dog to put review comment on PR

- Run linter the PR is against master branch
- Run linter when pull-request triggered
- Allow review dog to put review comment on PR

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/actions/reviewdog-permission-pr branch from cdef8aa to cd6edba Compare December 19, 2024 00:26
@miurahr miurahr merged commit 1f1d956 into master Dec 19, 2024
53 checks passed
@miurahr miurahr deleted the topic/miurahr/actions/reviewdog-permission-pr branch December 19, 2024 05:54
@tsteven4
Copy link
Contributor

@miurahr There are permission problems with reviewdog:

Run ./bin/reviewdog -runners=flake8,mypy -reporter=github-pr-review -conf=.reviewdog.yml
  ./bin/reviewdog -runners=flake8,mypy -reporter=github-pr-review -conf=.reviewdog.yml
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.1[2](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:2).8/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.8/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/[3](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:3).12.8/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.8/x6[4](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:4)
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.8/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.8/x64/lib
    REVIEWDOG_GITHUB_API_TOKEN: ***
time=2024-12-19T12:22:09.[5](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:5)89Z level=INFO msg="reviewdog: [start] runner=mypy"
time=2024-12-19T12:22:09.590Z level=INFO msg="reviewdog: [start] runner=flake8"
time=2024-12-19T12:22:11.581Z level=INFO msg="reviewdog: [finish] runner=flake8"
time=2024-12-19T12:22:13.[6](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:6)03Z level=INFO msg="reviewdog: [finish] runner=mypy\terror=exit status 1"
aqt/metadata.py:2[7](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:7)9:24: [mypy] error: Call to untyped function "Version" in typed
aqt/metadata.py:575:23: [mypy] error: Call to untyped function "Version" in typed
aqt/metadata.py:1012:69: [mypy] error: Call to untyped function "Version" in typed
time=2024-12-19T12:22:14.340Z level=INFO msg="reviewdog: failed to post a review comment: POST https://api.github.com/repos/miurahr/aqtinstall/pulls/[8](https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857#step:6:8)57/reviews: 403 Resource not accessible by integration []"
reviewdog: This GitHub Token doesn't have write permission of Review API [1],
so reviewdog will report results via logging command [2] and create annotations similar to
github-pr-check reporter as a fallback.
[1]: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
[2]: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions

for full log see https://github.com/miurahr/aqtinstall/actions/runs/12412582146/job/34652676794?pr=857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Linter execution does not report the issues
2 participants