chore: give pr permission for reviewdog (#862)

* chore: give pr permission for reviewdog - Run linter the PR is against master branch - Run linter when pull-request triggered - Allow review dog to put review comment on PR Signed-off-by: Hiroshi Miura <[email protected]> * chore: wip Signed-off-by: Hiroshi Miura <[email protected]> * chore: github actions jobs permissions Signed-off-by: Hiroshi Miura <[email protected]> * chore: ci: drop pylint from linter action Signed-off-by: Hiroshi Miura <[email protected]> --------- Signed-off-by: Hiroshi Miura <[email protected]>
miurahr · Dec 19, 2024 · 1f1d956 · 1f1d956
1 parent 8238543
commit 1f1d956
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -1,4 +1,4 @@
-name: Check tox tests, lint and types
+name: Check tox tests
 
 on:
   push:

diff --git a/.github/workflows/run-linter.yml b/.github/workflows/run-linter.yml
@@ -2,11 +2,19 @@ name: Run linter
 
 on:
   pull_request:
+    branches:
+      - master
+    types:
+      - opened
+      - synchronize
+      - reopened
 
 jobs:
   linter:
     name: Linter
     runs-on: ubuntu-24.04
+    permissions:
+      pull-requests: write
     steps:
       - uses: actions/checkout@v4
       - name: Setup python
@@ -23,7 +31,7 @@ jobs:
           pip install .[check]
       - name: run reviewdog
         run: |
-          ./bin/reviewdog -runners=flake8,mypy -reporter=github-pr-check -conf=.reviewdog.yml
+          ./bin/reviewdog -runners=flake8,mypy -reporter=github-pr-review -conf=.reviewdog.yml
         env:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}