Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Linter execution does not report the issues #861

Closed
1 task done
miurahr opened this issue Dec 18, 2024 · 4 comments · Fixed by #862
Closed
1 task done

[Bug]: Linter execution does not report the issues #861

miurahr opened this issue Dec 18, 2024 · 4 comments · Fixed by #862
Labels
bug Something isn't working

Comments

@miurahr
Copy link
Owner

miurahr commented Dec 18, 2024

Bug description

Github actions linter detects the issues but failed to put PR comment, when PR is created from forked repository.
There are also silently failed, but job is finished successfully, the linter execution.
We can observe the log in the inter job of PR# https://github.com/miurahr/aqtinstall/actions/runs/12384038278/job/34567887945

Expected behavior

Successfully put PR comment.

aqt and python version

N.A.

Operating System

Linux/Unix

Relevant log output

time=2024-12-18T00:40:06.471Z level=INFO msg="reviewdog: [start] runner=pylint"
time=2024-12-18T00:40:06.472Z level=INFO msg="reviewdog: [start] runner=flake8"
time=2024-12-18T00:40:06.472Z level=INFO msg="reviewdog: [start] runner=mypy"
time=2024-12-18T00:40:10.588Z level=INFO msg="reviewdog: [finish] runner=flake8"
time=2024-12-18T00:40:13.991Z level=INFO msg="reviewdog: [finish] runner=mypy\terror=exit status 1"
time=2024-12-18T00:40:16.782Z level=INFO msg="reviewdog: [finish] runner=pylint\terror=exit status 30"
aqt/metadata.py:279:24: [mypy] error: Call to untyped function "Version" in typed
aqt/metadata.py:575:23: [mypy] error: Call to untyped function "Version" in typed
aqt/metadata.py:1012:69: [mypy] error: Call to untyped function "Version" in typed
Error: [mypy] reported by reviewdog 🐶
error: Call to untyped function "Version" in typed

Raw Output:
aqt/metadata.py:279:24: error: Call to untyped function "Version" in typed
Error: [mypy] reported by reviewdog 🐶
error: Call to untyped function "Version" in typed

Raw Output:
aqt/metadata.py:575:23: error: Call to untyped function "Version" in typed
Error: [mypy] reported by reviewdog 🐶
error: Call to untyped function "Version" in typed

Raw Output:
aqt/metadata.py:1012:69: error: Call to untyped function "Version" in typed
aqt/metadata.py:279: [pylint] Line too long (101/100) (line-too-long)
aqt/metadata.py:279:8: [pylint] Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
aqt/metadata.py:574:4: [pylint] Missing function or method docstring (missing-function-docstring)
aqt/metadata.py:576:12: [pylint] Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
Error: [pylint] reported by reviewdog 🐶
Line too long (101/100) (line-too-long)

Raw Output:
aqt/metadata.py:279:0: C0301: Line too long (101/100) (line-too-long)
Error: [pylint] reported by reviewdog 🐶
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)

Raw Output:
aqt/metadata.py:279:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
Error: [pylint] reported by reviewdog 🐶
Missing function or method docstring (missing-function-docstring)

Raw Output:
aqt/metadata.py:574:4: C0116: Missing function or method docstring (missing-function-docstring)
Error: [pylint] reported by reviewdog 🐶
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)

Raw Output:
aqt/metadata.py:576:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@miurahr miurahr added bug Something isn't working triage and removed triage labels Dec 18, 2024
@tsteven4
Copy link
Contributor

I made one improvement but ran into a Github Large File Storage issue:

Fetching LFS objects
  /usr/bin/git lfs fetch origin refs/remotes/pull/857/merge
  fetch: Fetching reference refs/remotes/pull/857/merge
  batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.
  Error: error: failed to fetch some objects from 'https://github.com/miurahr/aqtinstall.git/info/lfs'

https://github.com/miurahr/aqtinstall/actions/runs/12404468523/job/34629662056

@tsteven4
Copy link
Contributor

@miurahr this looks like something you just changed
9f495db .github/workflows/check.yml (Hiroshi Miura 2024-12-17 11:18:20 +0900 23) lfs: true

@miurahr
Copy link
Owner Author

miurahr commented Dec 19, 2024

Thanks for my head up for the billing issue.

image

I don't know why but bandwidth is exceeded. I want to drop LFS configuration and items in it.

@miurahr
Copy link
Owner Author

miurahr commented Dec 19, 2024

Now I think the master branch disables LFS. Please check a head of master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants