Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick custom footer link changes #11

Merged
merged 12 commits into from
Feb 22, 2023
Merged

Conversation

asadali145
Copy link

@asadali145 asadali145 commented Feb 22, 2023

Description: This branch cherry-picks all the changes we made in frontend-component-footer. Here are the commit hashes:

7e17807
dcb2b11
2ed2992
64a1e58
4c8bfb0
ecae648
c18a4d8
863022d
2e11948
3334579
acfe0d3
b7967b4
809c39f
bc5d6e1
6a4c56a

Testing Guidelines:

  1. Follow the readme to configure the footer with the Learning MFE
  2. Configure the Footer links in .env.development of the Learning MFE and restart the MFE
  3. Links should be visible in footer.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #11 (d39af08) into master (b710800) will increase coverage by 3.75%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   81.25%   85.00%   +3.75%     
==========================================
  Files           4        4              
  Lines          32       40       +8     
  Branches        4       11       +7     
==========================================
+ Hits           26       34       +8     
  Misses          6        6              
Impacted Files Coverage Δ
src/components/Footer.jsx 82.75% <100.00%> (+6.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arslanashraf7 arslanashraf7 self-assigned this Feb 22, 2023
Copy link

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Please squash and merge this as a single commit into master so that it's easier to cherry-pick in the future.

@asadali145 asadali145 merged commit 126d372 into master Feb 22, 2023
@asadali145 asadali145 deleted the asad/cherry-picks branch March 17, 2023 12:21
asadali145 added a commit that referenced this pull request Dec 7, 2023
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
blarghmatey pushed a commit that referenced this pull request Dec 7, 2023
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
blarghmatey pushed a commit that referenced this pull request Jan 2, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
blarghmatey pushed a commit that referenced this pull request Jan 22, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
asadali145 added a commit that referenced this pull request Jan 23, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
asadali145 added a commit that referenced this pull request Jan 25, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
asadali145 added a commit that referenced this pull request Jan 25, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
asadali145 added a commit that referenced this pull request Feb 7, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
blarghmatey pushed a commit that referenced this pull request Mar 14, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
asadali145 added a commit that referenced this pull request Jul 2, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
asadali145 added a commit that referenced this pull request Jul 2, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
blarghmatey pushed a commit that referenced this pull request Jul 15, 2024
* refactor: added configurable and consistant footer as per MITX specifications.

* fix(packge.json): add MITX info

* fix: updated packge name

* fix: updated author name

* refactor: added prepare script

* fix: updated read me  and removed prepare scrpt

* fix: updated packages to resolve conflicts

* fix: added caret ranges

* fix: updated node version

* docs: fix typos (#8)

* refactor: update package-lock

* fix: fix failing tests

---------

Co-authored-by: Wassaf-Shahzad <[email protected]>
Co-authored-by: Arslan Ashraf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants