Skip to content

Commit

Permalink
Merge pull request #6 from mitodl/wassaf/add-documentaion
Browse files Browse the repository at this point in the history
updated read me  and resolved dependency conflict
  • Loading branch information
Wassaf-Shahzad authored Nov 16, 2021
2 parents 3334579 + acfe0d3 commit b7967b4
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 6 deletions.
24 changes: 24 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,30 @@ Build a production distribution::

npm run build

***********
Local Development
***********

For local development and testing follow these steps. (for convenince sake consider learning MFE as parent app)

* Clone frontend-component-footer-mitol into frontend-app-learning directory.
* CD into the frontend-component-footer-mitol and run the following commands::
npm i

npm build
* Verify a `dist/` forlder has been created.
* CD back into frontend-app-learning and create a module.config.js file
* Place the following code inf the module.config.js::
localModules: [
{ moduleName: '@edx/frontend-component-footer', dir: './frontend-component-footer-mitol' },
}
}

* Restart frontend-app-learning and verify it is using the local version from @edx/frontend-component-footer
* For css changes you might need to rebuild again.

.. |Build Status| image:: https://api.travis-ci.com/edx/frontend-component-footer.svg?branch=master
:target: https://travis-ci.com/edx/frontend-component-footer
.. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-component-footer
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"lint": "fedx-scripts eslint --ext .js --ext .jsx .",
"snapshot": "fedx-scripts jest --updateSnapshot",
"start": "fedx-scripts webpack-dev-server --progress",
"test": "fedx-scripts jest --coverage",
"prepare": "npm run build"
"test": "fedx-scripts jest --coverage"
},
"files": [
"/dist"
Expand Down Expand Up @@ -59,9 +58,9 @@
"@fortawesome/react-fontawesome": "0.1.16"
},
"peerDependencies": {
"@edx/frontend-platform": "^1.8.0",
"@edx/frontend-platform": "^1.12.7",
"prop-types": "^15.5.10",
"react": "^16.9.0",
"react-dom": "^16.9.0"
"react": "^17.0.2",
"react-dom": "^17.0.2"
}
}

0 comments on commit b7967b4

Please sign in to comment.