Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated read me and resolved dependency conflict #6

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

Wassaf-Shahzad
Copy link

@Wassaf-Shahzad Wassaf-Shahzad commented Nov 11, 2021

Description

This PR accomplishes the following tasks

  • Updated documentation for local development and testing
  • Updates Packages to resolve dependency conflict with @edx/frontend-platform

What are the relevant tickets

Closes #4

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #6 (2e11948) into master (c18a4d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files           4        4           
  Lines          45       45           
  Branches       12       12           
=======================================
  Hits           34       34           
  Misses         11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18a4d8...2e11948. Read the comment docs.

@Wassaf-Shahzad Wassaf-Shahzad force-pushed the wassaf/add-documentaion branch from 182d438 to 2e11948 Compare November 15, 2021 12:38
@Wassaf-Shahzad Wassaf-Shahzad changed the title updated read me and removed prepare script. updated read me and resolved dependency conflict Nov 15, 2021
Copy link

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation.
3 participants