forked from openedx/frontend-component-footer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cherry pick custom footer link changes (#11)
* refactor: added configurable and consistant footer as per MITX specifications. * fix(packge.json): add MITX info * fix: updated packge name * fix: updated author name * refactor: added prepare script * fix: updated read me and removed prepare scrpt * fix: updated packages to resolve conflicts * fix: added caret ranges * fix: updated node version * docs: fix typos (#8) * refactor: update package-lock * fix: fix failing tests --------- Co-authored-by: Wassaf-Shahzad <[email protected]> Co-authored-by: Arslan Ashraf <[email protected]>
- Loading branch information
1 parent
62bf038
commit 0b76468
Showing
7 changed files
with
289 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -184,16 +184,27 @@ Reporting Security Issues | |
========================= | ||
|
||
Please do not report security issues in public. Please email [email protected]. | ||
======= | ||
*********** | ||
Local Development | ||
*********** | ||
|
||
For local development and testing follow these steps. (for convenience sake consider learning MFE as parent app) | ||
|
||
* Clone frontend-component-footer-mitol into frontend-app-learning directory. | ||
* CD into the frontend-component-footer-mitol and run the following commands:: | ||
npm i | ||
|
||
npm build | ||
* Verify a `dist/` directory has been created. | ||
* CD back into frontend-app-learning and create a module.config.js file | ||
* Place the following code in the module.config.js:: | ||
|
||
module.exports = { | ||
localModules: [ | ||
{ moduleName: '@edx/frontend-component-footer', dir: './frontend-component-footer-mitol' }, | ||
} | ||
|
||
.. |Build Status| image:: https://api.travis-ci.com/edx/frontend-component-footer.svg?branch=master | ||
:target: https://travis-ci.com/edx/frontend-component-footer | ||
.. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-component-footer | ||
:target: @edx/frontend-component-footer | ||
.. |npm_version| image:: https://img.shields.io/npm/v/@edx/frontend-component-footer.svg | ||
:target: @edx/frontend-component-footer | ||
.. |npm_downloads| image:: https://img.shields.io/npm/dt/@edx/frontend-component-footer.svg | ||
:target: @edx/frontend-component-footer | ||
.. |license| image:: https://img.shields.io/npm/l/@edx/frontend-component-footer.svg | ||
:target: @edx/frontend-component-footer | ||
.. |semantic-release| image:: https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg | ||
:target: https://github.com/semantic-release/semantic-release | ||
* Restart frontend-app-learning and verify it is using the local version from @edx/frontend-component-footer | ||
* For css changes you might need to rebuild again. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,58 @@ | ||
$gray-footer: #fcfcfc !default; | ||
$link-blue: #006daa; | ||
|
||
.footer { | ||
background-color: $gray-footer; | ||
|
||
.copyright-col { | ||
display: flex; | ||
flex-direction: column; | ||
padding-left: 20px; | ||
padding-right: 20px; | ||
} | ||
} | ||
|
||
.footer-sub-nav { | ||
padding: 0; | ||
margin: 0 0 5px; | ||
list-style: none; | ||
font-size: 15px; | ||
line-height: 20px; | ||
|
||
@include media-breakpoint-down(md) { | ||
text-align: left; | ||
} | ||
|
||
@include media-breakpoint-up(md) { | ||
margin: 0; | ||
} | ||
|
||
li { | ||
display: inline-block; | ||
vertical-align: top; | ||
margin: 0; | ||
|
||
@include media-breakpoint-down(md) { | ||
display: block; | ||
margin: 0; | ||
padding: 0 0 7px; | ||
|
||
&::before { | ||
display: none; | ||
} | ||
} | ||
|
||
&::before { | ||
content: "-"; | ||
padding-left: 5px; | ||
padding-right: 5px; | ||
color: $link-blue | ||
} | ||
|
||
&:first-child { | ||
&::before { | ||
display: none; | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.