Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: support GEX (RFC 4419) and ECDH key exchanges #63

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented May 17, 2023

No description provided.

Copy link
Member

@reynir reynir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick read (of both the diff and rfc4419) I think this looks ok. However, it was a quick read and I am a bit tired now :-)

@hannesm hannesm merged commit a0dd360 into mirage:main Jun 13, 2023
@hannesm hannesm deleted the more-kex branch June 13, 2023 07:47
@hannesm
Copy link
Member Author

hannesm commented Jun 14, 2023

this broke the KEX (bad signatures)

@hannesm hannesm restored the more-kex branch June 14, 2023 10:16
@hannesm hannesm mentioned this pull request Jun 14, 2023
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jun 19, 2023
CHANGES:

* FEATURE server: propagate window-change message (mirage/awa-ssh#55 @reynir)
* FEATURE server: implement ext-info and server-sig-algs extension (mirage/awa-ssh#56 @reynir)
* FEATURE server: support RFC 4419 (group key exchanges) and NIST ECDH key
  exchanges, and X25519 (mirage/awa-ssh#63 mirage/awa-ssh#67 @hannesm)
* FEATURE server: handle unknown public keys (instead of closing the connection,
  send a message back, allowing other public keys to be probeb) (mirage/awa-ssh#68 @reynir)
* BUGFIX server: fix rekey (avoid allocating lots of timeout tasks (mirage/awa-ssh#58 @reynir)
* BUGFIX server: filter advertised host key algorithms with used host key
  (mirage/awa-ssh#62 @hannesm)
* server: use logs instead of printf (mirage/awa-ssh#69 @hannesm)
* awa-lwt: drop package (unused, mirage/awa-ssh#61 @hannesm)
* drop Driver module, embed into awa_test_server.ml (mirage/awa-ssh#64 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants