Ext info implementation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine, requires ocaml 4.10 though (please add a lower bound) |
|
Thanks! |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jun 19, 2023
CHANGES: * FEATURE server: propagate window-change message (mirage/awa-ssh#55 @reynir) * FEATURE server: implement ext-info and server-sig-algs extension (mirage/awa-ssh#56 @reynir) * FEATURE server: support RFC 4419 (group key exchanges) and NIST ECDH key exchanges, and X25519 (mirage/awa-ssh#63 mirage/awa-ssh#67 @hannesm) * FEATURE server: handle unknown public keys (instead of closing the connection, send a message back, allowing other public keys to be probeb) (mirage/awa-ssh#68 @reynir) * BUGFIX server: fix rekey (avoid allocating lots of timeout tasks (mirage/awa-ssh#58 @reynir) * BUGFIX server: filter advertised host key algorithms with used host key (mirage/awa-ssh#62 @hannesm) * server: use logs instead of printf (mirage/awa-ssh#69 @hannesm) * awa-lwt: drop package (unused, mirage/awa-ssh#61 @hannesm) * drop Driver module, embed into awa_test_server.ml (mirage/awa-ssh#64 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH2_MSG_EXT_INFOis a message type for communicating extensions. This PR implements parsing and serializing extension information messages. The server is as well extended to send theserver-sig-algsextension with available signature algorithms. This is necessary for newer openssh clients that want to use RSA keys.I am very open to changing the code as it was written somewhat in a hurry to get it working before a demo.