Server.kexinit: filter host key algorithms with these supported by the hostkey #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I suspect we need to do the same for the ext-info message |
|
nicely spotted, there was another occurence in rekey, which I adapted as well. please re-review |
reynir
approved these changes
May 17, 2023
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jun 19, 2023
CHANGES: * FEATURE server: propagate window-change message (mirage/awa-ssh#55 @reynir) * FEATURE server: implement ext-info and server-sig-algs extension (mirage/awa-ssh#56 @reynir) * FEATURE server: support RFC 4419 (group key exchanges) and NIST ECDH key exchanges, and X25519 (mirage/awa-ssh#63 mirage/awa-ssh#67 @hannesm) * FEATURE server: handle unknown public keys (instead of closing the connection, send a message back, allowing other public keys to be probeb) (mirage/awa-ssh#68 @reynir) * BUGFIX server: fix rekey (avoid allocating lots of timeout tasks (mirage/awa-ssh#58 @reynir) * BUGFIX server: filter advertised host key algorithms with used host key (mirage/awa-ssh#62 @hannesm) * server: use logs instead of printf (mirage/awa-ssh#69 @hannesm) * awa-lwt: drop package (unused, mirage/awa-ssh#61 @hannesm) * drop Driver module, embed into awa_test_server.ml (mirage/awa-ssh#64 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.