Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] RBAC built in privilege groups and grant v2 #37787

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Nov 18, 2024

cherry-pick from master: #37720, #37785
issue: #37031

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Nov 18, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@shaoting-huang Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 20, 2024
Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 84.74946% with 70 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (4aca68a) to head (37125e5).
Report is 5 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 84.01% 24 Missing and 11 partials ⚠️
internal/proxy/impl.go 66.66% 21 Missing and 9 partials ⚠️
pkg/util/constant.go 50.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37787      +/-   ##
==========================================
+ Coverage   72.24%   72.30%   +0.05%     
==========================================
  Files        1069     1070       +1     
  Lines      166979   167350     +371     
==========================================
+ Hits       120641   121007     +366     
- Misses      41919    41922       +3     
- Partials     4419     4421       +2     
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.98% <100.00%> (+0.11%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 97.33% <ø> (ø)
internal/proxy/privilege_interceptor.go 84.73% <100.00%> (+0.52%) ⬆️
internal/proxy/util.go 90.77% <100.00%> (+0.12%) ⬆️
pkg/util/paramtable/component_param.go 98.35% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/rbac_param.go 100.00% <100.00%> (ø)
pkg/util/constant.go 90.16% <50.00%> (-7.88%) ⬇️
internal/proxy/impl.go 85.26% <66.66%> (-0.31%) ⬇️
internal/rootcoord/root_coord.go 89.32% <84.01%> (-0.09%) ⬇️

... and 34 files with indirect coverage changes

---- 🚨 Try these New Features:

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhikunyao
Copy link
Collaborator

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 21, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 21, 2024
@weiliu1031
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Nov 22, 2024

@shaoting-huang Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Nov 22, 2024
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Nov 22, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 22, 2024
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 22, 2024
@shaoting-huang shaoting-huang changed the title enhance: [2.4] RBAC built in privilege groups enhance: [2.4] RBAC built in privilege groups and grant v2 Nov 22, 2024
Copy link
Contributor

mergify bot commented Nov 22, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 23, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang shaoting-huang force-pushed the builtin_pg_2.4 branch 2 times, most recently from 205321c to 424d3aa Compare November 24, 2024 01:02
Copy link
Contributor

mergify bot commented Nov 24, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d8f1af6 into milvus-io:2.4 Nov 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants