Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: RBAC built in privilege groups #37720

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

shaoting-huang
Copy link
Contributor

issue: #37031

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 15, 2024
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 15, 2024
Copy link
Contributor

mergify bot commented Nov 15, 2024

@shaoting-huang

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@shaoting-huang shaoting-huang changed the title RBAC built in privilege groups enhance: RBAC built in privilege groups Nov 15, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 15, 2024
Copy link
Contributor

mergify bot commented Nov 15, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (e9391ac) to head (efdd810).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 83.16% 12 Missing and 5 partials ⚠️
pkg/util/constant.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #37720    +/-   ##
========================================
  Coverage   80.68%   80.68%            
========================================
  Files        1357     1358     +1     
  Lines      190831   191024   +193     
========================================
+ Hits       153974   154135   +161     
- Misses      31436    31451    +15     
- Partials     5421     5438    +17     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.85% <ø> (ø)
Go 83.21% <90.32%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.35% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/rbac_param.go 100.00% <100.00%> (ø)
pkg/util/constant.go 90.90% <0.00%> (-7.14%) ⬇️
internal/rootcoord/root_coord.go 89.44% <83.16%> (-0.19%) ⬇️

... and 35 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 15, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

pkg/util/paramtable/rbac_param.go Outdated Show resolved Hide resolved
internal/rootcoord/meta_table.go Outdated Show resolved Hide resolved
internal/rootcoord/meta_table.go Outdated Show resolved Hide resolved
pkg/util/constant.go Outdated Show resolved Hide resolved
internal/rootcoord/root_coord.go Outdated Show resolved Hide resolved
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 18, 2024
@mergify mergify bot removed the ci-passed label Nov 18, 2024
Signed-off-by: shaoting-huang <[email protected]>
Copy link
Contributor

mergify bot commented Nov 18, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@weiliu1031
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2d72ad3 into milvus-io:master Nov 18, 2024
20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Nov 20, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 25, 2024
cherry-pick from master: #37720,
#37785
issue: #37031

Signed-off-by: shaoting-huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants