Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: RBAC new grant/revoke privilege #37785

Merged
merged 1 commit into from
Nov 21, 2024
Merged

enhance: RBAC new grant/revoke privilege #37785

merged 1 commit into from
Nov 21, 2024

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Nov 18, 2024 •
edited
Loading

issue: #37031
also fix issues: #37843, #37842, #37887

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 18, 2024
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test sig/testing test/integration integration test labels Nov 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.62411% with 49 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (e247ff9) to head (0e167d9).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/impl.go 66.66% 21 Missing and 9 partials ⚠️
internal/rootcoord/root_coord.go 86.86% 12 Missing and 6 partials ⚠️
pkg/util/constant.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37785       +/-   ##
===========================================
+ Coverage   68.87%   81.02%   +12.14%     
===========================================
  Files         289     1357     +1068     
  Lines       25481   190392   +164911     
===========================================
+ Hits        17551   154260   +136709     
- Misses       7930    30636    +22706     
- Partials        0     5496     +5496
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.19% <82.62%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.81% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/request_v2.go 97.33% <ø> (ø)
internal/proxy/privilege_interceptor.go 84.73% <100.00%> (ø)
internal/proxy/util.go 89.93% <100.00%> (ø)
pkg/util/constant.go 90.16% <83.33%> (ø)
internal/rootcoord/root_coord.go 89.55% <86.86%> (ø)
internal/proxy/impl.go 84.63% <66.66%> (ø)

... and 1061 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

smellthemoon
smellthemoon reviewed Nov 19, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@sre-ci-robot sre-ci-robot removed the lgtm label Nov 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weiliu1031
Copy link
Contributor

/lgtm

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 20, 2024
@mergify mergify bot removed the ci-passed label Nov 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang shaoting-huang force-pushed the grantv2 branch 2 times, most recently from f99530a to b1bbcd7 Compare November 21, 2024 07:29
@zhikunyao
Copy link
Collaborator

/run-cpu-e2e

@shaoting-huang
Copy link
Contributor Author

rerun-ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
RBAC grant/revoke privilege v2
0e167d9 
Signed-off-by: shaoting-huang <[email protected]>
@mergify mergify bot added the ci-passed label Nov 21, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 19572f5 into milvus-io:master Nov 21, 2024
20 checks passed
@shaoting-huang shaoting-huang mentioned this pull request Nov 22, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 25, 2024
@shaoting-huang
enhance: [2.4] RBAC built in privilege groups and grant v2 (#37787)
d8f1af6 
cherry-pick from master: #37720,
#37785
issue: #37031

Signed-off-by: shaoting-huang <[email protected]>
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@shaoting-huang @JsDove
enhance: RBAC new grant/revoke privilege (milvus-io#37785)
584403d 
issue: milvus-io#37031
also fix issues: milvus-io#37843,
milvus-io#37842,
milvus-io#37887

Signed-off-by: shaoting-huang <[email protected]>
@shaoting-huang shaoting-huang mentioned this pull request Dec 10, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smellthemoon smellthemoon smellthemoon left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

@czs007 czs007 Awaiting requested review from czs007

Assignees

@weiliu1031 weiliu1031

Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shaoting-huang @weiliu1031 @congqixia @sre-ci-robot @zhikunyao @smellthemoon