Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: milvus.yaml should be up-to-date with code #32168

Closed
1 task done
tedxu opened this issue Apr 11, 2024 · 1 comment
Closed
1 task done

[Enhancement]: milvus.yaml should be up-to-date with code #32168

tedxu opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@tedxu
Copy link
Contributor

tedxu commented Apr 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

milvus.yaml should be up-to-date with code to avoid conflicts.

Current milvus.yaml has already diverged with code long ago, the first thing is to do a sync up. To prevent future divergence, it would also be necessary to enforce a check in the building process.

Thanks to #22003 we've already had the building block to do the work mentioned above.

Why is this needed?

No response

Anything else?

No response

@tedxu tedxu added the kind/enhancement Issues or changes related to enhancement label Apr 11, 2024
@tedxu tedxu self-assigned this Apr 11, 2024
sre-ci-robot pushed a commit that referenced this issue Apr 16, 2024
See #32168

---------

Signed-off-by: Ted Xu <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Apr 19, 2024
Copy link

stale bot commented May 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 12, 2024
@stale stale bot closed this as completed May 19, 2024
sre-ci-robot pushed a commit that referenced this issue Jul 25, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
See milvus-io#32168

---------

Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
tedxu added a commit to tedxu/milvus that referenced this issue Aug 13, 2024
tedxu added a commit to tedxu/milvus that referenced this issue Aug 13, 2024
sre-ci-robot pushed a commit that referenced this issue Aug 13, 2024
tedxu added a commit that referenced this issue Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

1 participant