-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: update param documents #35152
enhance: update param documents #35152
Conversation
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
6b50daf
to
7d5fa31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35152 +/- ##
==========================================
+ Coverage 81.03% 81.05% +0.02%
==========================================
Files 1189 1189
Lines 143490 143548 +58
==========================================
+ Hits 116271 116360 +89
+ Misses 22798 22773 -25
+ Partials 4421 4415 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See: milvus-io#35161 --------- Signed-off-by: Ted Xu <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
See: milvus-io#35161 --------- Signed-off-by: Ted Xu <[email protected]>
See: milvus-io#35161 --------- Signed-off-by: Ted Xu <[email protected]>
See #32168 pr: #34567 #35152 --------- Signed-off-by: Ted Xu <[email protected]>
See: #35161