Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: adding the msgchannel section in generated yaml #35466

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Aug 14, 2024

See #32168

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 14, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (0868a97) to head (261eb27).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #35466       +/-   ##
===========================================
- Coverage   84.86%   72.45%   -12.42%     
===========================================
  Files         947     1225      +278     
  Lines      119935   143925    +23990     
===========================================
+ Hits       101787   104279     +2492     
- Misses      13717    35199    +21482     
- Partials     4431     4447       +16     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.50% <100.00%> (+0.01%) ⬆️

... and 310 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit c6ae7d4 into milvus-io:master Aug 14, 2024
14 of 15 checks passed
tedxu added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants