Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: url truncation #1012

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Fix: url truncation #1012

merged 3 commits into from
Jul 6, 2021

Conversation

thewahome
Copy link
Collaborator

Overview

Closes #979

Double encodes the # characters present in the url

Demo

N/A

Notes

N/A

Testing Instructions

  • Run GET https://graph.microsoft.com/v1.0/users/Nic#[email protected]

  • Observe message": "Request with $search query parameter only works through MSGraph with a special request header: 'ConsistencyLevel: eventual'",

  • Add the 'ConsistencyLevel: eventual' headers to the request

  • Run the query again and notice it does not fail

  • Run GET https://graph.microsoft.com/v1.0/users/Nic#[email protected]

  • The response will now indicate it can't find the user Nic#[email protected]

  • Look in Fiddler and observe that the full URL is sent.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1012.centralus.azurestaticapps.net

@thewahome thewahome merged commit f50c6f9 into dev Jul 6, 2021
thewahome added a commit that referenced this pull request Jul 6, 2021
* Fix: Accessibility bugs - June (#991) 

* Fix: Clear the user's profile on sign out (#1000)

* Fix: repopulate modify permissions when panel closed (#999)

* Fix: Accessibility bugs (Jul-Sep) (#1010)

* Task: Collect telemetry data for fetching adaptive card templates (#1004)

* Task: Capture telemetry for response headers copy action (#1003)

* Task: Add telemetry for Report an Issue Link (#1011)

* Fix: url truncation (#1012)
thewahome added a commit that referenced this pull request Jul 15, 2021
* Fix: improve themes MessageBar colors (#1015)

* Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008)

* Fix: url truncation (#1012)

* Fix: Response Preview truncation (#1017)

* Task: change sandbox URL (#992)
thewahome added a commit that referenced this pull request Jul 15, 2021
* Fix: url truncation (#1012)

* Fix: improve themes MessageBar colors (#1015)

* Fix: Response Preview truncation (#1017)

* Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008)

* Fix: terminate process on entering multiple slash (#824)

* Task: change sandbox url (#992)
@thewahome thewahome deleted the fix/url-truncation branch August 6, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Url truncation with # character requires encoding
3 participants