Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: change sandbox url #992

Merged
merged 15 commits into from
Jul 15, 2021
Merged

Task: change sandbox url #992

merged 15 commits into from
Jul 15, 2021

Conversation

thewahome
Copy link
Collaborator

Overview

To get the proxy url, we first make a call to the endpoint.
Store this in state
And use it to make subsequent calls

We fall back to the old proxy when this first call does not work

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@thewahome thewahome linked an issue Jun 15, 2021 that may be closed by this pull request
Move to the new sandbox APIs due to api sandbox proxy deprecation #879
Closed
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

ElinorW
ElinorW reviewed Jul 15, 2021
View reviewed changes
package.json Outdated
@@ -37,7 +37,7 @@
"guid-typescript": "1.0.9",
"html-webpack-plugin": "4.0.0-alpha.2",
"identity-obj-proxy": "3.0.0",
"isomorphic-fetch": "2.2.1",
"isomorphic-fetch": "^2.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the caret? or we can just stick to the 2.2.1 version?

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-992.centralus.azurestaticapps.net

@thewahome thewahome merged commit 054f0c5 into dev Jul 15, 2021
thewahome added a commit that referenced this pull request Jul 15, 2021
@thewahome
chore(release): 4.11.0 (#1030)
e6bc5f3 
* Fix: improve themes MessageBar colors (#1015)

* Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008)

* Fix: url truncation (#1012)

* Fix: Response Preview truncation (#1017)

* Task: change sandbox URL (#992)
thewahome added a commit that referenced this pull request Jul 15, 2021
@thewahome
chore(release): 4.11.0 (#1031)
19733ac 
* Fix: url truncation (#1012)

* Fix: improve themes MessageBar colors (#1015)

* Fix: Response Preview truncation (#1017)

* Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008)

* Fix: terminate process on entering multiple slash (#824)

* Task: change sandbox url (#992)
@thewahome thewahome deleted the task/change-sandbox-url branch August 6, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElinorW ElinorW ElinorW approved these changes

@Shjokie Shjokie Awaiting requested review from Shjokie

@ddyett ddyett Awaiting requested review from ddyett

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to the new sandbox APIs due to api sandbox proxy deprecation
2 participants
@thewahome @ElinorW