Fix: Accessibility bugs - June #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElinorW
requested review from
Shjokie,
ddyett and
millicentachieng
as code owners
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-991.centralus.azurestaticapps.net |
ElinorW
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-991.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-991.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-991.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-991.centralus.azurestaticapps.net |
thewahome
reviewed
Jun 16, 2021
Comment on lines
+47
to
+49
| return <MessageBar messageBarType={MessageBarType.blocked}> | ||
| <FormattedMessage id='Sign In to see your access token.' /> | ||
| </Label>; | ||
| </MessageBar>; |
thewahome
approved these changes
Jun 16, 2021
thewahome
added a commit
that referenced
this pull request
Jul 6, 2021
* Fix: Accessibility bugs - June (#991) * Fix: Clear the user's profile on sign out (#1000) * Fix: repopulate modify permissions when panel closed (#999) * Fix: Accessibility bugs (Jul-Sep) (#1010) * Task: Collect telemetry data for fetching adaptive card templates (#1004) * Task: Capture telemetry for response headers copy action (#1003) * Task: Add telemetry for Report an Issue Link (#1011) * Fix: url truncation (#1012)
acchiang
pushed a commit
to LokiLabs/microsoft-graph-explorer-v4
that referenced
this pull request
Jul 6, 2021
* correct aria-label for sign in button * Update ariaLabel for Expand/Collapse button * change from label component to messageBar * remove unused styling * adjust column width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes multiple accessibility issues present on GE:
Testing Instructions
Step 1: Open the above URL in Edge browser.
Step 2: Open Narrator using 'Win + Ctrl+ Enter' key.
Step 3: Navigate to Sign in to graph explorer button using the Tab key.
Step 4: Observe the Fix.
Step 5: Navigate to the History tab item for the page by the Tab and Right Arrow key and activate it.
Step 6: Navigate to the Expand collapse group button by Tab key and activate it.
Step 7: Observe the narration here
Step 8: Navigate to the Modified permission (Preview) button by tab key and activate it by using the Enter key.
Step 9: Observe 'Admin Consent required' column fix