-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use List instead of Tree for the QuickPick #29096
Comments
@isidorn Not sure how these widgets all work, but fyi in the standalone editor they are located in |
@bpasero I might look into this, any objections to assigning this to November? |
@isidorn sure feel free. this would probably have to go into |
Does the list implementation have virtualization support? I just wrote an extension where ideally one could search through about 30,000 items. Currently this is not feasible in terms of performance; the item elements probably would have to be created only when they are actually visible. |
@chrmarti can answer to that as he changed the underlying widget for the extensions picker just recently and I think this should improve performance at least for extensions. |
Performance has improved with the list widget, but there is no virtualization support in the API at the moment. There are a few cases where we still use the old implementation internally, the API always uses the list widget. Keeping this task around for the remaining cases. |
/duplicate #69955 |
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines. Happy Coding! |
Since QuickPick is a flat list It does not make sense to use the
Tree
as the implenetation mechanism we should use theList
instead.Refs: #27900
The text was updated successfully, but these errors were encountered: