Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use List instead of Tree for the QuickPick #29096

Closed
isidorn opened this issue Jun 20, 2017 · 8 comments
Closed

Use List instead of Tree for the QuickPick #29096

isidorn opened this issue Jun 20, 2017 · 8 comments
Assignees
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) perf quick-pick Quick-pick widget issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 20, 2017

Since QuickPick is a flat list It does not make sense to use the Tree as the implenetation mechanism we should use the List instead.
Refs: #27900

@isidorn isidorn added the debt Code quality issues label Jun 20, 2017
@isidorn isidorn self-assigned this Jun 20, 2017
@alexdima
Copy link
Member

@isidorn Not sure how these widgets all work, but fyi in the standalone editor they are located in src/vs/editor/standalone/browser/quickOpen

@isidorn isidorn added this to the Backlog milestone Jun 21, 2017
@bpasero bpasero added perf quick-pick Quick-pick widget issues labels Nov 11, 2017
@isidorn
Copy link
Contributor Author

isidorn commented Nov 13, 2017

@bpasero I might look into this, any objections to assigning this to November?

@bpasero
Copy link
Member

bpasero commented Nov 14, 2017

@isidorn sure feel free. this would probably have to go into quickOpenWidget.ts. I hope the list covers all the features we have from the tree...

@brunnerh
Copy link

Does the list implementation have virtualization support?

I just wrote an extension where ideally one could search through about 30,000 items. Currently this is not feasible in terms of performance; the item elements probably would have to be created only when they are actually visible.

@bpasero
Copy link
Member

bpasero commented May 26, 2018

@chrmarti can answer to that as he changed the underlying widget for the extensions picker just recently and I think this should improve performance at least for extensions.

@chrmarti
Copy link
Collaborator

Performance has improved with the list widget, but there is no virtualization support in the API at the moment.

There are a few cases where we still use the old implementation internally, the API always uses the list widget. Keeping this task around for the remaining cases.

@chrmarti chrmarti assigned chrmarti and unassigned isidorn May 28, 2018
@chrmarti chrmarti modified the milestones: Backlog, June 2018 May 28, 2018
@chrmarti chrmarti modified the milestones: June 2018, July 2018 Jun 27, 2018
@chrmarti chrmarti modified the milestones: July 2018, Backlog Jul 24, 2018
chrmarti added a commit that referenced this issue Aug 6, 2018
chrmarti added a commit that referenced this issue Aug 6, 2018
chrmarti added a commit that referenced this issue Aug 7, 2018
chrmarti added a commit that referenced this issue Aug 8, 2018
chrmarti added a commit that referenced this issue Aug 8, 2018
chrmarti added a commit that referenced this issue Aug 8, 2018
chrmarti added a commit that referenced this issue Aug 8, 2018
chrmarti added a commit that referenced this issue Aug 8, 2018
chrmarti added a commit that referenced this issue Aug 9, 2018
chrmarti added a commit that referenced this issue Aug 9, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
chrmarti added a commit that referenced this issue Aug 10, 2018
@bpasero
Copy link
Member

bpasero commented Oct 15, 2019

/duplicate #69955

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 15, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 15, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) perf quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

5 participants