Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickOpen: Rewrite using quick input widget #69955

Closed
5 tasks done
joaomoreno opened this issue Mar 7, 2019 · 17 comments
Closed
5 tasks done

QuickOpen: Rewrite using quick input widget #69955

joaomoreno opened this issue Mar 7, 2019 · 17 comments
Assignees
@bpasero @chrmarti
Labels
debt Code quality issues quick-pick Quick-pick widget issues
Milestone
March 2020

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 7, 2019 •
edited by bpasero
Loading

@joaomoreno joaomoreno added the debt Code quality issues label Mar 7, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Mar 7, 2019
@bpasero
Copy link
Member

bpasero commented Mar 7, 2019

@chrmarti fyi in order to use your QuickInput for quick open it would have to be accessible from vs/editor because we have some of the quick opens functional in the standalone editor.

@bpasero bpasero modified the milestones: Backlog, On Deck Mar 7, 2019
@joaomoreno joaomoreno mentioned this issue Mar 21, 2019
Merged
@bpasero bpasero mentioned this issue Mar 28, 2019
Closed
sandy081 added a commit that referenced this issue Apr 1, 2019
@sandy081
#69955 Adopt to new tree
a2e8a03
@sandy081
Copy link
Member

sandy081 commented Apr 1, 2019

@joaomoreno indent option is not working here:

https://github.com/Microsoft/vscode/blob/a2e8a03d55cde707b6d56b1c3532f37b442a86b0/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts#L206

@joaomoreno
Copy link
Member Author

@sandy081 What do you mean?

@sandy081
Copy link
Member

sandy081 commented Apr 2, 2019

I have different indentation for extension deps/pack tree. But the new tree is not respecting the indentation value I provide.

@isidorn isidorn mentioned this issue Jul 8, 2019
Closed
@joaomoreno
Copy link
Member Author

Custom trees have adopted. 🎆

We're getting closer

rebornix added a commit to rebornix/vscode that referenced this issue Aug 5, 2019
@rebornix
Re microsoft#69955. Adopt new tree in comments panel.
c17bb3e
rebornix added a commit that referenced this issue Aug 6, 2019
@rebornix
Merge pull request #78532 from rebornix/rebornix/newtree-in-comments
c02c6a9 
Re #69955. Adopt new tree in comments panel.
@rebornix
Copy link
Member

rebornix commented Aug 6, 2019

Comments panel already adopted the new tree.

@joaomoreno
Copy link
Member Author

@rebornix Fantastic!

@joaomoreno joaomoreno removed this from the On Deck milestone Oct 15, 2019
@joaomoreno
Copy link
Member Author

@chrmarti @bpasero Feel free to pass it back to me once quick open adopts the tree.

@bpasero bpasero changed the title Adopt list/new tree across workbench in order to delete the old tree QuickOpen: adopt new tree Oct 15, 2019
@joaomoreno
Copy link
Member Author

Yey!

Merging perf issue here: #84945

@joaomoreno joaomoreno mentioned this issue Nov 19, 2019
Closed
@kieferrm kieferrm mentioned this issue Dec 29, 2019
Closed
40 tasks
@bpasero bpasero mentioned this issue Jan 9, 2020
Closed
@bpasero bpasero changed the title QuickOpen: Adopt list widget QuickOpen: Rewrite using quick input widget Jan 13, 2020
@bpasero bpasero modified the milestones: January 2020, February 2020 Jan 24, 2020
chrmarti added a commit that referenced this issue Feb 6, 2020
@chrmarti
Move QuickInput to base layer (#69955)
db7795f
chrmarti added a commit that referenced this issue Feb 6, 2020
@chrmarti
Move QuickInput to base layer (#69955)
7fab6bf
@egamma egamma mentioned this issue Feb 10, 2020
Closed
54 tasks
@bpasero bpasero modified the milestones: February 2020, March 2020 Feb 19, 2020
@kieferrm kieferrm mentioned this issue Mar 8, 2020
Closed
55 tasks
@bpasero bpasero mentioned this issue Mar 9, 2020
Merged
@bpasero bpasero mentioned this issue Mar 16, 2020
Closed
@bpasero
Copy link
Member

bpasero commented Mar 22, 2020

Status:

  • quick open via quick input can be enabled via "workbench.quickOpen.enableExperimentalNewVersion": true
  • will probably change the default sometime next week for more selfhosting coverage
  • can then delete old code once we feel comfortable either end of milestone or in debt week

@bpasero bpasero closed this as completed Mar 26, 2020
This was referenced Mar 28, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 31, 2020
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@chrmarti chrmarti

Labels
debt Code quality issues quick-pick Quick-pick widget issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
5 participants
@joaomoreno @rebornix @bpasero @chrmarti @sandy081