-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree: set aria-setsize and aria-posinset #27900
Comments
Makes sense, I can look into it in june |
Accidently closed this by PR which only address the list widget, still gotta do it for the tree |
After looking into this with @joaomoreno we have fixed this issue for the list, however for the tree the situation is a bit more complex:
Due to that we would need a bigger refactoring in order to fix this for the tree. So renaming this issue and pushing it to backlog for now. |
The originating issue -- microsoft/monaco-editor#444 -- came in w.r.t. the Command Palette that displays a list. @bpasero perhaps the root issue is that the implementation of the Command Palette uses a tree to display a list and that makes it difficult to express the list to Screen Readers ? |
+1 for making the command palette use the list. I could also look into this when I get cycles if @bpasero does not mind. |
@isidorn yeah +1 for using list for quick open, that would be very nice 👍 . I hope there are no things in tree that quick open depends on. |
I have created this issue to track it #29096 |
The tree/list is virtualized and as such a screen reader cannot make a correct statement on the number of entries. We should leverage aria-setsize and aria-posinset for that purpose within the tree and list widgets. The widgets know the number of elements to render and the currently selected items position in the set.
/cc @joaomoreno @isidorn
The text was updated successfully, but these errors were encountered: