Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim terminal text should have half the minimum contrast ratio #190371

Closed
Tyriar opened this issue Aug 13, 2023 · 1 comment · Fixed by #190417
Closed

Dim terminal text should have half the minimum contrast ratio #190371

Tyriar opened this issue Aug 13, 2023 · 1 comment · Fixed by #190417
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 13, 2023

See #178162 for an example of why this is an issue

Repro:

  • Set a high minimum contrast ratio in settings
  • Run echo -e '\x1b[31mNormal \x1b[31;2mDim\x1b[0m', 🐛 provided the minimum contrast ratio is not too high, the colors should differ

Actual:

Image

Expected:

Image
@Tyriar Tyriar added this to the August 2023 milestone Aug 13, 2023
@Tyriar Tyriar self-assigned this Aug 13, 2023
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream terminal-rendering labels Aug 13, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Aug 13, 2023

Upstream: xtermjs/xterm.js#4262

Tyriar added a commit that referenced this issue Aug 14, 2023
@Tyriar
[email protected]
0c6b510 
Fixes #190374
Fixes #190371
@Tyriar Tyriar mentioned this issue Aug 14, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 14, 2023
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 28, 2023
@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

[email protected] microsoft/vscode
3 participants
@Tyriar @alexr00 @vscodenpa