Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM renderer does not show selection over regular background colors #190374

Closed
Tyriar opened this issue Aug 13, 2023 · 3 comments · Fixed by #190417
Closed

DOM renderer does not show selection over regular background colors #190374

Tyriar opened this issue Aug 13, 2023 · 3 comments · Fixed by #190417
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 13, 2023

When gpuAcceleration = 'off', the yellow text background should be blue here:

image

@Tyriar Tyriar added this to the August 2023 milestone Aug 13, 2023
@Tyriar Tyriar self-assigned this Aug 13, 2023
@Tyriar Tyriar added the feature-request Request for new features or functionality label Aug 14, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Aug 14, 2023

Upstream: xtermjs/xterm.js#4097

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Aug 14, 2023
Tyriar added a commit that referenced this issue Aug 14, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 14, 2023
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 28, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 29, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented Aug 29, 2023

The rendering's interesting.

  1. Open an editor and an integrated terminal. Run the git diff command in the integrated terminal and select a large chunk of text like in the original comment.
  2. Focus the editor.
  3. ❗The colour of parts of the selection in the integrated terminal changes.
    Example of step 3

@Tyriar
Copy link
Member Author

Tyriar commented Aug 29, 2023

@rzhao271 good eye, I think that counts as a bug as it's certainly unexpected from my perspective. A repro emphasising what's going on is to set the color customization "terminal.inactiveSelectionBackground": "#ff0000" which results in this:

image

Created xtermjs/xterm.js#4736

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants