Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dim attribute should have half the minimum contrast ratio demands #4262

Closed
Tyriar opened this issue Nov 11, 2022 · 0 comments · Fixed by #4672
Closed

The dim attribute should have half the minimum contrast ratio demands #4262

Tyriar opened this issue Nov 11, 2022 · 0 comments · Fixed by #4672
Assignees
@Tyriar
Labels
area/accessibility type/bug Something is misbehaving
Milestone
5.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 11, 2022

See PowerShell/PSReadLine#3477
@Tyriar Tyriar added type/bug Something is misbehaving area/accessibility labels Nov 11, 2022
@Tyriar Tyriar mentioned this issue Jan 19, 2023
Closed
@Tyriar Tyriar mentioned this issue May 30, 2023
Open
@Tyriar Tyriar mentioned this issue Aug 3, 2023
Closed
@Tyriar Tyriar mentioned this issue Aug 13, 2023
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 13, 2023
@Tyriar
Enforce half minimum contrast ratio for dim text
1cef30c 
Provided MCR is not too high, this ensures dim text differs from normal
text and has a reasonable difference in contrast.

Fixes xtermjs#4262
@Tyriar Tyriar mentioned this issue Aug 13, 2023
Merged
@Tyriar Tyriar self-assigned this Aug 13, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/accessibility type/bug Something is misbehaving
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Enforce half minimum contrast ratio for dim text Tyriar/xterm.js
1 participant
@Tyriar