Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win 11 Windows Control Overlay Stopped Working With 1.71.2 #161218

Closed
iDad5 opened this issue Sep 19, 2022 · 4 comments · Fixed by #167060
Closed

Win 11 Windows Control Overlay Stopped Working With 1.71.2 #161218

iDad5 opened this issue Sep 19, 2022 · 4 comments · Fixed by #167060
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan windows VS Code on Windows issues workbench-os-integration Native OS integration issues
Milestone

Comments

@iDad5
Copy link

iDad5 commented Sep 19, 2022

Does this issue occur when all extensions are disabled?: Yes/No
Yes it does

  • VS Code Version: 1.71.2
  • OS Version: win 11

Windows 11 adds the "SnapLayouts" feature to the maximize/restore button in the titel-bar of any window. When you hover over the button the flyout appears and let's you choose a window layout. The feature can also be activated by pressing Win + z on the keyboard.

The flyout worked as expected in 1.71.1 it started not to appear with 1.71.2 the keyboard shortcut still works.

[All the Snap-Layout features are enabled systemwide on my machine, and other windows still show the flyout as expexted.]

@rzhao271
Copy link
Contributor

We call it the window controls overlay (WCO). The WCO was disabled this iteration because of #159813. That issue has been closed, but it was closed by disabling the feature. We're currently investigating a longer-term solution to enable the WCO without causing that regression again. See PR #159958 for details.

@rzhao271 rzhao271 added *as-designed Described behavior is as designed and removed *as-designed Described behavior is as designed labels Sep 26, 2022
@vscodenpa
Copy link

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2022
@rzhao271
Copy link
Contributor

Actually, since #159813 is closed, I can keep this issue open to track enabling the WCO again.

@rzhao271 rzhao271 reopened this Sep 26, 2022
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2022
@rzhao271 rzhao271 added this to the October 2022 milestone Sep 26, 2022
@rzhao271 rzhao271 changed the title Win 11 Snap-Laput Flyout Stopped Working With 1.71.2 Win 11 Windows Control Overlay Stopped Working With 1.71.2 Oct 6, 2022
@rzhao271 rzhao271 added the workbench-os-integration Native OS integration issues label Oct 6, 2022
@rzhao271 rzhao271 modified the milestones: October 2022, November 2022 Oct 21, 2022
@rzhao271 rzhao271 added the windows VS Code on Windows issues label Nov 22, 2022
rzhao271 added a commit that referenced this issue Nov 23, 2022
rzhao271 added a commit that referenced this issue Nov 23, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 23, 2022
@rzhao271
Copy link
Contributor

Verification steps:

  1. On Windows 11 with VS Code Insiders, enable the window controls overlay setting in VS Code, reloading the program if prompted.
  2. Hover over the restore/maximize button.
  3. A layout should appear showing tiling options for the window.

@vscodenpa vscodenpa added on-testplan insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan windows VS Code on Windows issues workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants