Test: Language pack recommendation with different locales

[rzhao271]

Refs: #161218

• macOS @lszomoru
• linux @lramos15
• windows @meganrogge

Complexity: 5

Authors: @rzhao271, @TylerLeonhardt

Create Issue

---

Electron now receives the application locale so that it can display the window controls overlay component properly on Windows and macOS. At the same time, I added in a new API to Electron that VS Code calls from main.js, so that the language pack recommender can continue to recommend language packs even with the Electron change.

For the instructions below, French (fr) can be replaced with another language that we have a language pack for that is not pseudolanguage (qps-ploc). Therefore, instead of French, one can use a language like Spanish (es) or Simplified Chinese (zh-cn).

Scenario 1: Locale unset

1. Run the "Preferences: Configure Runtime Arguments" command to open argv.json.
2. Make sure there is no "locale" key-value pair set.
3. Make sure the French language pack is not installed.
4. Switch the system language to French. On Windows, change French to be the first preferred language instead (which differs from the system language).
5. Close VS code completely and open it again.
6. On macOS, VS Code should be in French. On Linux and Windows, there should be a notification alerting users that they can install and change the application language to French.
7. Accept the notification.
8. Run the "Preferences: Configure Runtime Arguments" command to open argv.json.
9. The "locale" key should have "fr" as the value.

Scenario 2: Locale set to non-English language

1. Run the "Preferences: Configure Runtime Arguments" command to open argv.json.
2. Set the locale to "fr"
3. Make sure the French language pack is not installed.
4. Switch the system language to English. On Windows, change English to be the first preferred language instead (which differs from the system language).
5. Close VS code completely and open it again.
6. On macOS, VS Code should be in French. On Linux and Windows, there should be a notification alerting users that they can install and change the application language to French.

Scenario 3: Locale set to English

1. Run the "Preferences: Configure Runtime Arguments" command to open argv.json.
2. Set the locale to "en"
3. Make sure the French language pack is not installed.
4. Switch the system language to French. On Windows, change French to be the first preferred language instead (which differs from the system language).
5. Close VS code completely and open it again.
6. On macOS, VS Code should be in English. On Linux and Windows, VS Code should be in English. No language pack recommendation notification should appear.

Scenario 4: Locale overridden by command-line flag

1. Run the "Preferences: Configure Runtime Arguments" command to open argv.json.
2. Set the locale to "zh-cn" and the system language to English. On Windows, change English to be the first preferred language instead (which differs from the system language).
3. Make sure the French language pack is not installed.
4. Close VS code completely and open it from the command line using the flag --locale=fr.
5. On macOS, VS Code should be in French. On Linux and Windows, there should be a notification alerting users that they can install and change the application language to French.

Scenario 5: Pseudolanguage and RTL system languages

1. Switch the system language to a right-to-left language like Arabic. On Windows, change the first preferred language instead (which differs from the system language).
2. If you're on Windows, ensure the window controls overlay setting is enabled.
3. Change the display language to pseudolanguage (qps-ploc).
4. Close VS code completely and open it again.
5. VS Code should be in pseudolanguage. On macOS, the traffic lights should still be on the left side. On Windows, the window controls overlay should still be on the right side. On Linux, the close button should be on the same side as it was in the previous scenarios.