Layout control in the wrong place for RTL macOS

[tom-programming]

Version of VS Code: 1.72.2

Your operating system: macOS 10.15.7

List of extensions that you have installed: none

Reproducible steps (1... 2... 3...) that cause the issue:

Set the OS language to Hebrew or Arabic. Then open VSCode

What you expected to see, versus what you actually saw

I expect to see the layout control buttons in the left side when the window is RTL, because in the right side there are the close/minimize/resize OS buttons.

Instead they are in the right side and the are basically impossible to click because they are covered with the window buttons.

See image:

[rzhao271]

Confirmed on macOS Monterey with the titlebar style set to "custom" and the system language set to Arabic.

[rzhao271]

Related: #161218

[rzhao271]

Verification steps:

1. On macOS, switch the most preferred system language to a right-to-left language such as Arabic.
2. On VS Code Insiders, set the titlebar style to custom in the settings, reloading the program if prompted.
3. The traffic lights should still be on the left side.

[lramos15]

@rzhao271 verified this, but isn't it expected that the traffic lights and WCO actually switch so that traffic lights are on the right and the WCO is on the left when using a RTL language?

[rzhao271]

Reopening this issue because the current fix is even less usable, i.e. #167543

[rzhao271]

@sbatten and I looked into other programs on macOS, and it seems that all non-Electron-based programs have the traffic lights on the right side when the system language is Arabic.

An invalid assumption I had was that because Windows set the location of the window controls overlay (WCO) depending on the application language, that macOS would do something similar. Instead, we should just move over the layout controls, as was originally asked.

Not a duplicate of #161218

[sbatten]

Verification Steps:

1. On macOS, set your OS language to an RTL language such as Arabic.
2. Restart the machine
3. Start VS Code, traffic controls should be on the right side
4. Layout controls in the custom title bar should show to the left of the controls