[post build lint] Check for absolute paths

include/vcpkg/base/messages.h

@@ -267,6 +267,8 @@ namespace vcpkg::msg
     DECLARE_MSG_ARG(option, "editable");
     DECLARE_MSG_ARG(package_name, "zlib");
     DECLARE_MSG_ARG(path, "/foo/bar");
+    DECLARE_MSG_ARG(paths, "/foo/bar, /foo/bar2");
+    DECLARE_MSG_ARG(absolute_paths, "/foo/bar, /foo/bar2");
     DECLARE_MSG_ARG(row, "42");
     DECLARE_MSG_ARG(spec, "zlib:x64-windows");
     DECLARE_MSG_ARG(system_api, "CreateProcessW");
@@ -820,6 +822,11 @@ namespace vcpkg
                     "One or more {vendor} credential providers failed to authenticate. See '{url}' for more details "
                     "on how to provide credentials.");
     DECLARE_MESSAGE(FeedbackAppreciated, (), "", "Thank you for your feedback!");
+    DECLARE_MESSAGE(FilesContainAbsolutePath,
+                    (msg::absolute_paths, msg::paths),
+                    "The ('{absolute_paths}') part should remain unchanged, as a list of paths",
+                    "The following files contain an absolute path ('{absolute_paths}'): {paths}\n"
+                    "There should be no absolute paths in the installed package, only relative ones.");
     DECLARE_MESSAGE(FishCompletion, (msg::path), "", "vcpkg fish completion is already added at \"{path}\".");
     DECLARE_MESSAGE(
         ForceSystemBinariesOnWeirdPlatforms,

include/vcpkg/base/util.h

@@ -233,6 +233,13 @@ namespace vcpkg::Util
         return std::find(begin(cont), end(cont), v);
     }
 
+    template<class Range, class T>
+    bool contains(const Range& r, const T& el)
+    {
+        using std::end;
+        return Util::find(r, el) != end(r);
+    }
+
     template<class Container, class Pred>
     auto find_if(Container&& cont, Pred pred)
     {

locales/messages.en.json

@@ -138,6 +138,7 @@
   "FailedToStoreBinaryCache": "Failed to store binary cache {path}",
   "FailedVendorAuthentication": "One or more {vendor} credential providers failed to authenticate. See '{url}' for more details on how to provide credentials.",
   "FeedbackAppreciated": "Thank you for your feedback!",
+  "FilesContainAbsolutePath": "The following files contain an absolute path ('{absolute_paths}'): {paths}\nThere should be no absolute paths in the installed package, only relative ones.",
   "FishCompletion": "vcpkg fish completion is already added at \"{path}\".",
   "ForceSystemBinariesOnWeirdPlatforms": "Environment variable VCPKG_FORCE_SYSTEM_BINARIES must be set on arm, s390x, and ppc64le platforms.",
   "FormattedParseMessageExpression": "on expression: {value}",

locales/messages.json

@@ -243,6 +243,8 @@
   "FailedVendorAuthentication": "One or more {vendor} credential providers failed to authenticate. See '{url}' for more details on how to provide credentials.",
   "_FailedVendorAuthentication.comment": "An example of {vendor} is Azure. An example of {url} is https://github.com/microsoft/vcpkg.",
   "FeedbackAppreciated": "Thank you for your feedback!",
+  "FilesContainAbsolutePath": "The following files contain an absolute path ('{absolute_paths}'): {paths}\nThere should be no absolute paths in the installed package, only relative ones.",
+  "_FilesContainAbsolutePath.comment": "The ('{absolute_paths}') part should remain unchanged, as a list of paths An example of {absolute_paths} is /foo/bar, /foo/bar2. An example of {paths} is /foo/bar, /foo/bar2.",
   "FishCompletion": "vcpkg fish completion is already added at \"{path}\".",
   "_FishCompletion.comment": "An example of {path} is /foo/bar.",
   "ForceSystemBinariesOnWeirdPlatforms": "Environment variable VCPKG_FORCE_SYSTEM_BINARIES must be set on arm, s390x, and ppc64le platforms.",

src/vcpkg/base/messages.cpp

@@ -542,6 +542,7 @@ namespace vcpkg
     REGISTER_MESSAGE(FailedVendorAuthentication);
     REGISTER_MESSAGE(FeedbackAppreciated);
     REGISTER_MESSAGE(FishCompletion);
+    REGISTER_MESSAGE(FilesContainAbsolutePath);
     REGISTER_MESSAGE(ForceSystemBinariesOnWeirdPlatforms);
     REGISTER_MESSAGE(FormattedParseMessageExpression);
     REGISTER_MESSAGE(GenerateMsgErrorParsingFormatArgs);

src/vcpkg/postbuildlint.cpp

@@ -1,10 +1,12 @@
 #include <vcpkg/base/cofffilereader.h>
 #include <vcpkg/base/files.h>
+#include <vcpkg/base/messages.h>
 #include <vcpkg/base/system.print.h>
 #include <vcpkg/base/system.process.h>
 #include <vcpkg/base/util.h>
 
 #include <vcpkg/build.h>
+#include <vcpkg/installedpaths.h>
 #include <vcpkg/packagespec.h>
 #include <vcpkg/postbuildlint.buildtype.h>
 #include <vcpkg/postbuildlint.h>
@@ -1025,6 +1027,101 @@ namespace vcpkg::PostBuildLint
         return LintStatus::SUCCESS;
     }
 
+    static LintStatus check_no_absolute_paths_in(const Filesystem& fs, const Path& dir, Span<Path> absolute_paths)
+    {
+        static constexpr StringLiteral extensions[] = {"h", "hpp", "hxx", "py", "sh", "cmake", "pc", "cfg", "conf"};
+        std::vector<std::pair<Path, std::string>> files_and_contents;
+        for (auto& path : fs.get_regular_files_recursive(dir, IgnoreErrors{}))
+        {
+            if (path.extension().empty())
+            {
+                auto contents = fs.read_contents(path, VCPKG_LINE_INFO);
+                if (Strings::starts_with(contents, "#!"))
+                {
+                    files_and_contents.emplace_back(std::move(path), std::move(contents));
+                }
+            }
+            else if (Util::contains(extensions, path.extension().substr(1 /* ignore dot */)))
+            {
+                auto contents = fs.read_contents(path, VCPKG_LINE_INFO);
+                files_and_contents.emplace_back(std::move(path), std::move(contents));
+            }
+        }
+        std::vector<std::string> string_paths;
+        for (const auto& path : absolute_paths)
+        {
+#if defined(_WIN32)
+            auto path_preferred = path;
+            path_preferred.make_preferred();
+            string_paths.push_back(path_preferred.generic_u8string());
+            string_paths.push_back(std::move(path).native());
+#else
+            string_paths.push_back(path.native());
+#endif
+        }
+
+        std::string result;
+        for (const auto& path_and_contents : files_and_contents)
+        {
+            const auto extension = path_and_contents.first.extension().substr(1 /* ignore dot */);
+            const bool is_header = extension == "h" || extension == "hpp" || extension == "hxx";
+            if (Util::any_of(string_paths, [&path_and_contents, extension, is_header](const std::string& path) {
+                    if (extension == "cfg" || extension == "conf")
+                    {
+                        return Strings::contains(path_and_contents.second, path);
+                    }
+                    for (size_t offset = 0;;)
+                    {
+                        const auto index = path_and_contents.second.find(path, offset);
+                        if (index == std::string::npos) return false;
+                        if (is_header)
+                        {
+                            bool new_line = false;
+                            for (auto start = index;;)
+                            {
+                                const auto before = path_and_contents.second.find_last_of("\n/", start);
+                                if (before == std::string::npos) return true;
+                                if (path_and_contents.second[before] == '\n')
+                                {
+                                    if (before == 0) return true;
+                                    new_line = true;
+                                    start = before - 1;
+                                    continue;
+                                }
+                                if (path_and_contents.second[before + 1] == '*') break;              // is in a comment
+                                if (before == 0) return true;                                        // not in a comment
+                                if (!new_line && path_and_contents.second[before - 1] == '/') break; // is in a comment
+                                if (path_and_contents.second[before - 1] == '*') return true; // is not in a comment
+                                start = before - 1;
+                            }
+                        }
+                        else
+                        { // .py, .sh, .cmake or .pc file
+                            const auto before = path_and_contents.second.find_last_of("\n#", index);
+                            if (before == std::string::npos) return true;
+                            if (path_and_contents.second[before] == '\n') return true; // not a comment
+                        }
+                        offset = index + path.size();
+                    }
+                }))
+            {
+                result += "\n    ";
+                result += path_and_contents.first.native();
+            }
+        }
+
+        if (!result.empty())
+        {
+            msg::print(Color::warning,
+                       msg::format(msgFilesContainAbsolutePath,
+                                   msg::absolute_paths = Strings::join("', '", absolute_paths),
+                                   msg::paths = result)
+                           .append_raw("\n\n"));
+            return LintStatus::PROBLEM_DETECTED;
+        }
+        return LintStatus::SUCCESS;
+    }
+
     static void operator+=(size_t& left, const LintStatus& right) { left += static_cast<size_t>(right); }
 
     static size_t perform_all_checks_and_return_error_count(const PackageSpec& spec,
@@ -1153,6 +1250,10 @@ namespace vcpkg::PostBuildLint
         error_count += check_no_files_in_dir(fs, package_dir);
         error_count += check_no_files_in_dir(fs, package_dir / "debug");
         error_count += check_pkgconfig_dir_only_in_lib_dir(fs, package_dir);
+        error_count += check_no_absolute_paths_in(
+            fs,
+            package_dir,
+            std::vector<Path>{package_dir.native(), paths.installed().root().native(), paths.build_dir(spec)});
 
         return error_count;
     }