Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post build lint] Check for absolute paths #172

Merged
merged 68 commits into from
Jan 20, 2023
Merged
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
863231d
[post build lint] Check for absolute paths
autoantwort Aug 25, 2021
15778b6
Apply suggestions from code review
autoantwort Oct 7, 2021
9212d1b
Fix build and logic
autoantwort Oct 7, 2021
326672e
Merge branch 'main' into check-pkg-config-files
autoantwort Oct 12, 2021
cef8cb0
nicole's CRs
strega-nil-ms Oct 18, 2021
761dc17
fix build
autoantwort Oct 19, 2021
7fd595a
Merge branch 'main' into check-pkg-config-files
autoantwort Oct 29, 2021
7e9fdd0
Ignore dot in extension
autoantwort Oct 29, 2021
f58d9ae
Merge branch 'main' into check-pkg-config-files
autoantwort Nov 9, 2021
6840f39
fix build
autoantwort Nov 9, 2021
d7f0f47
Merge branch 'main' into check-pkg-config-files
autoantwort Nov 20, 2021
42c62d7
fix build
autoantwort Nov 20, 2021
80704ee
don't check .la files
autoantwort Nov 21, 2021
2c1fb86
also check for the buildtree dir
autoantwort Nov 23, 2021
cd19401
Merge branch 'main' into check-pkg-config-files
autoantwort Nov 27, 2021
1fd5a30
don't check .yaml files
autoantwort Nov 28, 2021
6154d36
ignore comments in files
autoantwort Dec 1, 2021
47787c5
Merge branch 'main' into check-pkg-config-files
autoantwort Dec 21, 2021
86072b7
adapt code
autoantwort Dec 21, 2021
ea1e189
fix comment detection
autoantwort Dec 24, 2021
10049d7
Update include/vcpkg/base/util.h
autoantwort Dec 30, 2021
03d24cd
Change order of conditions
autoantwort Dec 30, 2021
b51e0b1
Update src/vcpkg/postbuildlint.cpp
autoantwort Dec 30, 2021
5d19692
Use localized message
autoantwort Dec 31, 2021
b48fd0f
Merge branch 'main' into check-pkg-config-files
autoantwort Dec 31, 2021
81c991d
Update message map
autoantwort Dec 31, 2021
aa5264b
Merge branch 'main' into check-pkg-config-files
autoantwort Feb 21, 2022
8b2cc5c
Merge branch 'main' into check-pkg-config-files
autoantwort Mar 6, 2022
d58b64e
Update messages.en.json
autoantwort Mar 8, 2022
6db65d5
Merge branch 'main' into check-pkg-config-files
autoantwort Mar 24, 2022
04e77f5
Merge branch 'main' into check-pkg-config-files
autoantwort Apr 8, 2022
dce3e55
Merge branch 'main' into check-pkg-config-files
autoantwort Apr 18, 2022
9df3a83
Merge branch 'main' into check-pkg-config-files
autoantwort May 12, 2022
dec596d
Merge branch 'main' into check-pkg-config-files
autoantwort May 19, 2022
20a0747
Merge remote-tracking branch 'origin/main' into check-pkg-config-files
BillyONeal May 20, 2022
cc4cbc8
Merge branch 'main' into check-pkg-config-files
autoantwort Jun 25, 2022
7b535b4
No line endings in message
autoantwort Jun 25, 2022
dfa58d3
Merge remote-tracking branch 'origin/main' into check-pkg-config-files
BillyONeal Aug 11, 2022
3fd3ea2
Merge remote-tracking branch 'origin/main' into check-pkg-config-files
BillyONeal Aug 18, 2022
024b814
Apply the if/return transform requested by https://github.com/microso…
BillyONeal Aug 18, 2022
a1b3aa1
Merge remote-tracking branch 'origin/main' into check-pkg-config-files
BillyONeal Aug 22, 2022
6421db4
Merge branch 'main' into check-pkg-config-files
autoantwort Sep 2, 2022
bdcb84c
Merge branch 'main' into check-pkg-config-files
autoantwort Sep 26, 2022
2da94b4
Merge remote-tracking branch 'origin/main' into check-pkg-config-files
BillyONeal Sep 30, 2022
535e47a
Merge branch 'main' into check-pkg-config-files
autoantwort Oct 7, 2022
72476ba
Add policy to disable absolute paths check
autoantwort Oct 7, 2022
646525c
Make code more testable
autoantwort Oct 16, 2022
9b0c5f8
Fix wrong if
autoantwort Oct 18, 2022
2329d8d
Fix performace
autoantwort Oct 19, 2022
771a5a1
Use std::string::find != std::string::npos instead of Strings::contai…
autoantwort Oct 19, 2022
1994010
Merge branch 'main' into check-pkg-config-files
autoantwort Oct 19, 2022
2df175b
Fix warnings
autoantwort Oct 19, 2022
23c9e7d
Merge branch 'main' into check-pkg-config-files
autoantwort Oct 28, 2022
0a5c013
Merge branch 'main' into check-pkg-config-files
autoantwort Nov 3, 2022
028dd92
Merge remote-tracking branch 'origin/main' into check-pkg-config-files
BillyONeal Nov 17, 2022
a2a42d5
Fix detection of the end of raw strings literals and copy tests from …
autoantwort Nov 17, 2022
4092884
No optimization
autoantwort Nov 17, 2022
22c3d0e
Fix paths on windows
autoantwort Nov 17, 2022
c1188c6
No need for .native()
autoantwort Nov 17, 2022
f8b77a2
More tests and less memory usage
autoantwort Nov 19, 2022
0937195
Don't search for downloads folder
autoantwort Nov 19, 2022
bc23f1f
Ignore hash comments in .conf files
autoantwort Nov 28, 2022
298a2f4
Fix formatting
autoantwort Nov 28, 2022
4fabb06
Fix buffer overflow
autoantwort Nov 28, 2022
ed7e9c8
Merge branch 'main' into check-pkg-config-files
autoantwort Dec 5, 2022
cc3f741
Add e2e tests
autoantwort Dec 8, 2022
ccf6b23
Merge branch 'main' into check-pkg-config-files
autoantwort Jan 18, 2023
5222349
Adapt ee7bb9819253c8c440105b055e2b7f06e2a204a1
autoantwort Jan 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment detection
autoantwort committed Dec 24, 2021
commit ea1e189f1edd4ffdd7d8a15400b6e0803aaebbb0
3 changes: 1 addition & 2 deletions src/vcpkg/postbuildlint.cpp
Original file line number Diff line number Diff line change
@@ -1034,8 +1034,7 @@ namespace vcpkg::PostBuildLint
if (path_and_contents.second[before + 1] == '*') break; // is in a comment
if (before == 0) return true; // not in a comment
if (!new_line && path_and_contents.second[before - 1] == '/') break; // is in a comment
if (!new_line && path_and_contents.second[before - 1] == '*')
return true; // is not in a comment
if (path_and_contents.second[before - 1] == '*') return true; // is not in a comment
start = before - 1;
}
}