Fix warnings

include/vcpkg/base/span.h

@@ -26,7 +26,6 @@ namespace vcpkg
         constexpr Span(std::nullptr_t) noexcept : m_ptr(nullptr), m_count(0) { }
         constexpr Span(pointer ptr, size_t count) noexcept : m_ptr(ptr), m_count(count) { }
         constexpr Span(pointer ptr_begin, pointer ptr_end) noexcept : m_ptr(ptr_begin), m_count(ptr_end - ptr_begin) { }
-        constexpr Span(const std::initializer_list<T>& list) noexcept : m_ptr(list.begin()), m_count(list.size()) { }
 
         template<size_t N>
         constexpr Span(T (&arr)[N]) noexcept : m_ptr(arr), m_count(N)

src/vcpkg-test/strings.cpp

@@ -59,17 +59,18 @@ TEST_CASE ("find_first_of", "[strings]")
 TEST_CASE ("contains_any_ignoring_c_comments", "[strings]")
 {
     using vcpkg::Strings::contains_any_ignoring_c_comments;
-    REQUIRE(contains_any_ignoring_c_comments(R"(abc)", {"abc"}));
-    REQUIRE(contains_any_ignoring_c_comments(R"("abc")", {"abc"}));
-    REQUIRE_FALSE(contains_any_ignoring_c_comments(R"("" //abc)", {"abc"}));
-    REQUIRE_FALSE(contains_any_ignoring_c_comments(R"(/*abc*/ "")", {"abc"}));
-    REQUIRE_FALSE(contains_any_ignoring_c_comments("// test \\\nabc", {"abc"}));
-    REQUIRE(contains_any_ignoring_c_comments("\"//\" test \\\nabc", {"abc"}));
-    REQUIRE(contains_any_ignoring_c_comments(R"(R"-( // abc )-")", {"abc"}));
-    REQUIRE(contains_any_ignoring_c_comments(R"(R"-( /* abc */ )-")", {"abc"}));
-    REQUIRE(contains_any_ignoring_c_comments(R"(R"-()- /* abc */ )-")", {"abc"}));
-    REQUIRE(contains_any_ignoring_c_comments(R"(qwer )", {"abc", "wer"}));
-    REQUIRE(contains_any_ignoring_c_comments("\"a\" \"g\" // er \n test)", {"test"}));
+    vcpkg::StringView to_find[] = {"abc", "wer"};
+    REQUIRE(contains_any_ignoring_c_comments(R"(abc)", to_find));
+    REQUIRE(contains_any_ignoring_c_comments(R"("abc")", to_find));
+    REQUIRE_FALSE(contains_any_ignoring_c_comments(R"("" //abc)", to_find));
+    REQUIRE_FALSE(contains_any_ignoring_c_comments(R"(/*abc*/ "")", to_find));
+    REQUIRE_FALSE(contains_any_ignoring_c_comments("// test \\\nabc", to_find));
+    REQUIRE(contains_any_ignoring_c_comments("\"//\" test \\\nabc", to_find));
+    REQUIRE(contains_any_ignoring_c_comments(R"(R"-( // abc )-")", to_find));
+    REQUIRE(contains_any_ignoring_c_comments(R"(R"-( /* abc */ )-")", to_find));
+    REQUIRE(contains_any_ignoring_c_comments(R"(R"-()- /* abc */ )-")", to_find));
+    REQUIRE(contains_any_ignoring_c_comments(R"(qwer )", to_find));
+    REQUIRE(contains_any_ignoring_c_comments("\"a\" \"g\" // er \n abc)", to_find));
 }
 
 TEST_CASE ("edit distance", "[strings]")