-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Parameter & PropertyDeclaration Classes Instead of Records #3450
Make Parameter & PropertyDeclaration Classes Instead of Records #3450
Conversation
...s/http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/MethodSignature.cs
Show resolved
Hide resolved
API change check API changes are not detected in this pull request. |
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Show resolved
Hide resolved
...ttp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/IndexerDeclaration.cs
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/Parameter.cs
Show resolved
Hide resolved
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Show resolved
Hide resolved
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Outdated
Show resolved
Hide resolved
So I do not think we want to close the
These classes are defining a member in CSharp language therefore I think when our plugin writer is writing something, they might always need to write something that does not come from the spec, therefore they might need to construct their own parameter or field or property. Also I think it makes more sense to construct a parameter/field/property from input if those are not ctors but static methods. |
...http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/ModelTypeProvider.cs
Show resolved
Hide resolved
...http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/ModelTypeProvider.cs
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/Parameter.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Writers/CodeWriter.cs
Show resolved
Hide resolved
...arp/generator/Microsoft.Generator.CSharp/src/OutputTypes/ChangeTrackingDictionaryProvider.cs
Outdated
Show resolved
Hide resolved
Follow up to #3450. This PR updates the `FieldDeclaration` from a record to a class to follow the pattern set by PropertyDeclaration.
This PR updates the
Parameter
andPropertyDeclaration
types by converted them into classes and adds constructors to build both types from anInputModelProperty
.