Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fielddeclaration to a class #3492

Merged

Conversation

jorgerangel-msft
Copy link
Contributor

@jorgerangel-msft jorgerangel-msft commented May 31, 2024

Follow up to #3450. This PR updates the FieldDeclaration from a record to a class to follow the pattern set by PropertyDeclaration.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label May 31, 2024
@jorgerangel-msft jorgerangel-msft marked this pull request as ready for review May 31, 2024 15:32
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

@jorgerangel-msft jorgerangel-msft requested a review from m-nash May 31, 2024 17:58
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Jun 3, 2024
Merged via the queue into microsoft:main with commit 085129c Jun 3, 2024
21 checks passed
@jorgerangel-msft jorgerangel-msft deleted the update-fielddeclaration branch June 3, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants