Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Parameter Validation to Method Body Construction #3486

Closed
jorgerangel-msft opened this issue May 30, 2024 · 0 comments · Fixed by #3581
Closed

Move Parameter Validation to Method Body Construction #3486

jorgerangel-msft opened this issue May 30, 2024 · 0 comments · Fixed by #3581
Assignees
@m-nash
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@jorgerangel-msft
Copy link
Contributor

jorgerangel-msft commented May 30, 2024 •
edited
Loading

Originally opened as a result of this discussion. Currently, a Parameter type contains information about what validation it should have within a method. Since we are moving towards a model where the writer does not need to know this information, we should move the validation to occur whenever we construct a method's body, and not the parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-nash m-nash

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to consolidate parameter validation logic m-nash/typespec
2 participants
@m-nash @jorgerangel-msft