-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add parallel_tool_calls attribute to OpenAI chat prompt execution settings #9479
Merged
moonbox3
merged 3 commits into
microsoft:main
from
moonbox3:auto-func-calling-attribute
Oct 30, 2024
Merged
Python: Add parallel_tool_calls attribute to OpenAI chat prompt execution settings #9479
moonbox3
merged 3 commits into
microsoft:main
from
moonbox3:auto-func-calling-attribute
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Oct 30, 2024
alliscode
approved these changes
Oct 30, 2024
esttenorio
reviewed
Oct 30, 2024
..._kernel/connectors/ai/open_ai/prompt_execution_settings/open_ai_prompt_execution_settings.py
Show resolved
Hide resolved
esttenorio
approved these changes
Oct 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2024
alliscode
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
OpenAI / Azure OpenAI released the ability to specify the
parallel_tool_calls
= True | False boolean attribute on the prompt execution settings in July. This was never brought into SK Python.Further, there appears to be a pesky bug related to function calling where enabling parallel tool calls can cause 500s. The only way to get around this is to disable parallel function calling. This has been both tested on the Azure Chat Completion and OpenAI Chat Completion code and works well -- the chat history shows the synchronous function calls if multiple tool calls are required.
Description
Add the
parallel_tool_calls
attribute on the OpenAIChatPromptExecutionExecution settings, which are also used by the AzureChatCompletionClass.Contribution Checklist