[rush] child_process.spawnSync on windows must set shell: true when targeting a .cmd file #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-polinsky
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
|
@microsoft-github-policy-service agree company="Bentley Systems" |
dmichon-msft
changed the title
dmichon-msft
approved these changes
Apr 11, 2024
common/changes/@microsoft/rush/fix-spawnsync-windows_2024-04-11-22-28.json
Outdated
Show resolved
Hide resolved
Co-authored-by: David Michon <[email protected]>
…1-22-28.json Co-authored-by: David Michon <[email protected]>
ben-polinsky
changed the title
Thanks - PR title and description updated. |
ben-polinsky
changed the title
common/changes/@microsoft/rush/fix-spawnsync-windows_2024-04-11-22-28.json
Outdated
Show resolved
Hide resolved
7 tasks
fannheyward
added a commit
to neoclide/coc.nvim
that referenced
this pull request
Apr 19, 2024
Closes neoclide/coc-prettier#178 Latest version of Node.js needs to set `shell: true` to spawn option - node-red/node-red#4652 - microsoft/rushstack#4637
fannheyward
added a commit
to neoclide/coc.nvim
that referenced
this pull request
Apr 19, 2024
Closes neoclide/coc-prettier#178 Latest version of Node.js needs to set `shell: true` to spawn option - node-red/node-red#4652 - microsoft/rushstack#4637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adapt to Node.js security release, which disallows .bat and .cmd file spawning without enabling the shell option. As @dmichon-msft notes below, Rush invokes npm bin stubs which are
.CMDfiles on Windows.Fixes #4636
Details
Add
shell: truetochild_process.spawnSyncoptions when running in Windows, and ensure any path or binstub invoked is formatted appropriately.How it was tested
On both MacOS and Windows:
node ./libraries/rush-lib/dist/scripts/run-rush-install.js installandnode ./libraries/rush-lib/dist/scripts/run-rush-install.js rebuildsuccessfully.