Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use previously working node version until rush issue is fixed (backport #6611) [release/4.5.x] #6616

Merged
merged 11 commits into from
Apr 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 12, 2024

Latest nodejs security patch breaks rush integration on Windows: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2/

This can get builds moving again until the issue is fixed. We can also hold if we think it's worth waiting for.

See:


This is an automatic backport of pull request #6611 done by [Mergify](https://mergify.com).

DanRod1999 and others added 4 commits April 12, 2024 13:28
Co-authored-by: Ben Polinsky <[email protected]>
(cherry picked from commit 3a8593d)

# Conflicts:
#	common/changes/@itwin/core-backend/mitigate-rush-nodejs-lts-builds_2024-04-12-18-10.json
#	common/config/azure-pipelines/ci.yaml
#	common/config/azure-pipelines/integration-validation.yaml
#	common/config/azure-pipelines/jobs/fast-ci.yaml
#	common/config/rush/pnpm-lock.yaml
Copy link
Contributor Author

mergify bot commented Apr 12, 2024

Cherry-pick of 3a8593d has failed:

On branch mergify/bp/release/4.5.x/pr-6611
Your branch is up to date with 'origin/release/4.5.x'.

You are currently cherry-picking commit 3a8593d961.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   common/config/azure-pipelines/jobs/docs-build.yaml
	modified:   common/config/rush/pnpm-config.json
	modified:   core/backend/package.json
	modified:   test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle
	modified:   test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj
	modified:   tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   common/changes/@itwin/core-backend/mitigate-rush-nodejs-lts-builds_2024-04-12-18-10.json
	both modified:   common/config/azure-pipelines/ci.yaml
	both modified:   common/config/azure-pipelines/integration-validation.yaml
	both modified:   common/config/azure-pipelines/jobs/fast-ci.yaml
	both modified:   common/config/rush/pnpm-lock.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team April 12, 2024 19:47
@ben-polinsky ben-polinsky enabled auto-merge (squash) April 12, 2024 20:11
@aruniverse
Copy link
Member

@mdastous-bentley can you take a look at failing map-layers-auth tests?

@mdastous-bentley
Copy link
Contributor

@mdastous-bentley can you take a look at failing map-layers-auth tests?

@aruniverse Should be good now... I used fetch-mock package to solve the problem.

@hl662
Copy link
Contributor

hl662 commented Apr 15, 2024

/azp run iTwin.js

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ben-polinsky and others added 3 commits April 15, 2024 10:27
@ben-polinsky ben-polinsky disabled auto-merge April 15, 2024 15:57
@ben-polinsky ben-polinsky enabled auto-merge (squash) April 15, 2024 15:57
@aruniverse aruniverse disabled auto-merge April 15, 2024 15:59
@aruniverse aruniverse merged commit ae7f200 into release/4.5.x Apr 15, 2024
16 checks passed
@aruniverse aruniverse deleted the mergify/bp/release/4.5.x/pr-6611 branch April 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants