Deploy from layout #4945
Merged
Deploy from layout #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean we can stop generating the .pfx key files as well? Or will that still be needed for layout installs? |
dannyvv
reviewed
May 19, 2020
vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CSharpApp.targets
Outdated
Show resolved
Hide resolved
dannyvv
reviewed
May 19, 2020
vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CSharpApp.targets
Outdated
Show resolved
Hide resolved
dannyvv
reviewed
May 19, 2020
vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CSharpApp.targets
Show resolved
Hide resolved
dannyvv
reviewed
May 19, 2020
@dannyvv it's not strictly needed for layout installs but they are needed for appx. We still produce the appx even in Debug (so that you can carry the appx to a different machine and install it there), but installing from layout avoids having to elevate to install the certificate and is faster than installing an APPX |
* Reduce need for custom metro configs * Change files * Fix for integration tests
…tive-windows into deployFromLayout
change/react-native-windows-2020-05-17-09-26-39-MS_CallbackMultiArgs.json
Show resolved
Hide resolved
dannyvv
approved these changes
May 19, 2020
vmoroz
reviewed
May 19, 2020
ZihanChen-MSFT
pushed a commit
to ZihanChen-MSFT/react-native-windows
that referenced
this pull request
May 22, 2020
* deploy from layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio is able to deploy a UWP app from layout (i.e. without installing the APPX). This has several benefits for inner-loop development: installing an APPX requires elevation to pre-install the certificate that was used to sign the APPX with, which is unnecessary and cumbersome for Debug builds while you're writing the app.
This workflow works well in VS, however the command-line experience is broken. There are docs for Add-AppxPackage which tell us how to register a UWP app from layout. This seems to work for native apps but it doesn't work for .net UWP apps: apps will crash on launch. The symptom is that the desktop .net framework gets loaded instead of the .net framework for UWP.
As part of #4749 we disabled layout registration due to these UWP dotnet issues.
This PR fixes #4760 (the follow up bug to reenable .net UWP layout registration in Debug mode)
More details here
Microsoft Reviewers: Open in CodeFlow