-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the changes in our custom metro config #4939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Trusting your discretion on how to handle back-porting and documenting if we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 7 hours 14 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Reduce need for custom metro configs * Change files * Fix for integration tests
* Reduce need for custom metro configs * Change files * Fix for integration tests
A new version of the CLI has been published which included my fix for supporting out of tree platforms.
This allows us to stop specifying custom resolveRequest, getModulesRunBeforeMainModule and assetRegistryPath settings in our metro configs.
We should consider porting this to 0.62. The downside is that if they updated to 0.62 earlier, their lock file will probably be pointing to an older version of the CLI which wont support the new react-native.config.js. -- Hopefully this is something we can document in some troubleshooting section of the docs or something.
Microsoft Reviewers: Open in CodeFlow