App projects only builds from clean (i.e. the first time only) #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
approved these changes
May 21, 2020
asklar
added
the
AutoMerge
|
Hello @asklar! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours 55 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dannyvv
approved these changes
May 22, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…e which gets imported
ZihanChen-MSFT
pushed a commit
to ZihanChen-MSFT/react-native-windows
that referenced
this pull request
May 22, 2020
…soft#4983) * Fix deploy issue causing 2nd+ builds to break due to bug in appxrecipe which gets imported * Change files
nasadigital
pushed a commit
to nasadigital/react-native-windows
that referenced
this pull request
May 26, 2020
…soft#4983) * Fix deploy issue causing 2nd+ builds to break due to bug in appxrecipe which gets imported * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #4945 introduced an issue that manifests as projects not being able to be built more than once (or without a Clean pass).
The issue is that we Import the AppxRecipe file which has a bug in that the
ResolvedSDKReferenceitems are expected to have anOriginalItemSpecattribute in them, but they aren't being produced as such. When the build runs after we've built once already, we import these items from the appxrecipe, which lack this attribute, and the build breaks.The fix is to only do the import conditional on a new variable which gets set by the CLI on deploy. The Deploy target is made conditional on this variable too.
Microsoft Reviewers: Open in CodeFlow