Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflection checks to assert ReactMethod return type #5

Closed
rozele opened this issue Dec 17, 2015 · 0 comments
Closed

Add reflection checks to assert ReactMethod return type #5

rozele opened this issue Dec 17, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@rozele
Copy link
Collaborator

rozele commented Dec 17, 2015

Ensure that ReactMethods return void (or else throw).

@rozele rozele self-assigned this Dec 17, 2015
@rozele rozele added this to the V1 Core milestone Dec 17, 2015
rozele added a commit that referenced this issue Dec 22, 2015
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue Dec 22, 2015
@rozele rozele added ready and removed in progress labels Dec 22, 2015
@rozele rozele closed this as completed Dec 28, 2015
@rozele rozele removed the ready label Dec 28, 2015
rozele added a commit that referenced this issue Feb 21, 2016
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue Mar 1, 2016
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue Apr 21, 2016
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue May 17, 2016
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue May 18, 2016
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
GantMan referenced this issue in infinitered/react-native-windows Sep 29, 2016
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
randy-flynn added a commit that referenced this issue Apr 4, 2019
kmelmon added a commit that referenced this issue Aug 18, 2020
* re-enable

* comment out PlatformColor test, this was the failing test in the past as well

* trying again, this time commenting out PanResponder Sample, which comes just before the failing test

* trying to wait for home page to load before continuing

* another take on waiting for item in FlatList to be loaded first

* trying new approach, enter test name in edit box to filter first

* made some progress, now timing out on edit control, add polling for that control

* finally!  success.  Try #2

* try #3, fingers crossed!

* try #4

* split test into groups

* bumping up timeout

* try #2 with longer timeout

* go back to one testspec

* try #4 with longer timeout

* try #5 with longer timeout.  really folks I think I got it this time :)

* convert all the tests to use same mechanism

* Change files

* remove smoke test

* stability pass after removing smoke test, try #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant