Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Promises (part 1) #8

Closed
rozele opened this issue Dec 18, 2015 · 0 comments
Closed

Add support for Promises (part 1) #8

rozele opened this issue Dec 18, 2015 · 0 comments
Assignees
@rozele
Milestone
V1 Core

Comments

@rozele
Copy link
Collaborator

rozele commented Dec 18, 2015

Currently, we have the ICallback interface that allows users to respond to JavaScript with callback hooks. We also need support for promises.
rozele added a commit that referenced this issue Dec 22, 2015
@rozele
Fixes #5, fixes #8
7efd40d 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
@rozele rozele self-assigned this Dec 22, 2015
rozele added a commit that referenced this issue Dec 22, 2015
@rozele
Merge pull request #16 from CatalystCode/issue8
da89cbb 
Fixes #5, fixes #8
@rozele rozele added ready and removed in progress labels Dec 22, 2015
@erikschlegel erikschlegel added this to the V1 Core milestone Dec 28, 2015
@rozele rozele closed this as completed Dec 28, 2015
@rozele rozele removed the ready label Dec 28, 2015
rozele added a commit that referenced this issue Feb 21, 2016
@rozele
Fixes #5, fixes #8
cccfd12 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue Mar 1, 2016
@rozele
Fixes #5, fixes #8
4ec1fae 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
ebragge added a commit that referenced this issue Apr 8, 2016
@ebragge
feat(PushNotificationModule): add PushNotificationModule
8e895ee 
PushNotificationModule provides access to badges, toast and remote push notifications for React Native JavaScript applications.

Fixes #8
ebragge added a commit that referenced this issue Apr 20, 2016
@ebragge
feat(PushNotificationModule): add PushNotificationModule
f036b06 
PushNotificationModule provides access to badges, toast and remote push notifications for React Native JavaScript applications.

Fixes #8
rozele added a commit that referenced this issue Apr 21, 2016
@rozele
Fixes #5, fixes #8
85aec12 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
ebragge added a commit that referenced this issue Apr 28, 2016
@ebragge
feat(PushNotificationModule): add PushNotificationModule
7f67985 
PushNotificationModule provides access to badges, toast and remote push notifications for React Native JavaScript applications.

Fixes #8
rozele added a commit that referenced this issue May 17, 2016
@rozele
Fixes #5, fixes #8
dfeb4f0 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
rozele added a commit that referenced this issue May 18, 2016
@rozele
Fixes #5, fixes #8
1a17fac 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
GantMan pushed a commit to infinitered/react-native-windows that referenced this issue Sep 29, 2016
@rozele @GantMan
Fixes #5, fixes microsoft#8
27b81a3 
Adds support for IPromise arguments in the last argument of native module methods.

Additionally, adds checks during module initialization to ensure native module methods abide by the expected contract (i.e., void or Task return type, positioning of ICallback and IPromise arguments, etc.).
@reseul reseul mentioned this issue Jan 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozele rozele

Labels
None yet
Projects
None yet
Milestone
V1 Core
Development

No branches or pull requests
2 participants
@rozele @erikschlegel