fix(electron): after v28.0

[mxschmitt]

Fixes #28048
Relates electron/electron#40501

[github-actions]

Test results for "tests 1"

5 flaky

⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks

26277 passed, 615 skipped
✔️✔️✔️

Merge workflow run.

[github-actions]

Test results for "tests 2"

2 fatal errors, not part of any test
8 failed
❌ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
❌ [webkit] › page/page-screenshot.spec.ts:691:5 › page screenshot animations › should fire transitionend for finite transitions
❌ [webkit] › page/page-screenshot.spec.ts:718:5 › page screenshot animations › should capture screenshots after layoutchanges in transitionend event
❌ [webkit] › page/page-screenshot.spec.ts:691:5 › page screenshot animations › should fire transitionend for finite transitions
❌ [webkit] › page/page-screenshot.spec.ts:718:5 › page screenshot animations › should capture screenshots after layoutchanges in transitionend event

96 flaky

⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-evaluate.spec.ts:507:3 › should transfer 100Mb of data from page to node.js
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:283:3 › should click
⚠️ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:158:7 › cli codegen › should work with TrustedTypes
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:291:7 › cli codegen › should fill textarea
⚠️ [chromium] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [chromium] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
⚠️ [chromium] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:139:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/headful.spec.ts:55:3 › should not crash when creating second context
⚠️ [chromium] › library/headful.spec.ts:68:3 › should click when viewport size is larger than screen
⚠️ [chromium] › library/headful.spec.ts:83:3 › should dispatch click events to oversized viewports
⚠️ [chromium] › library/headful.spec.ts:107:3 › should click background tab
⚠️ [chromium] › library/headful.spec.ts:121:3 › should(not) block third party cookies
⚠️ [chromium] › library/headful.spec.ts:157:3 › should not block third party SameSite=None cookies
⚠️ [chromium] › library/headful.spec.ts:193:3 › should not override viewport size when passed null
⚠️ [chromium] › library/headful.spec.ts:211:3 › Page.bringToFront should work
⚠️ [chromium] › library/headful.spec.ts:287:3 › headless and headful should use same default fonts
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:235:3 › should report google.com frame with headed
⚠️ [chromium] › library/trace-viewer.spec.ts:930:1 › should prefer later resource request with the same method
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [chromium] › library/headful.spec.ts:55:3 › should not crash when creating second context
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/browsercontext-basic.spec.ts:236:3 › should work with offline option
⚠️ [firefox] › library/capabilities.spec.ts:99:3 › should play audio @smoke
⚠️ [firefox] › library/browsercontext-basic.spec.ts:236:3 › should work with offline option
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts:255:3 › requestFullscreen
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [firefox] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › page/page-drag.spec.ts:178:5 › Drag and drop › should respect the drop effect
⚠️ [firefox] › library/browsercontext-page-event.spec.ts:143:3 › should fire page lifecycle events
⚠️ [firefox] › library/download.spec.ts:529:5 › download event › should be able to cancel pending downloads
⚠️ [firefox] › library/hit-target.spec.ts:446:3 › should click in custom element
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts:99:3 › should play audio @smoke
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library/capabilities.spec.ts:99:3 › should play audio @smoke
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:283:3 › should click
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:315:3 › should emit filechooser event for iframe
⚠️ [chromium] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local
⚠️ [chromium] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-evaluate.spec.ts:199:3 › should reject promise with exception
⚠️ [webkit] › page/page-evaluate.spec.ts:507:3 › should transfer 100Mb of data from page to node.js
⚠️ [webkit] › page/page-event-console.spec.ts:38:3 › should emit same log twice
⚠️ [webkit] › page/selectors-vue.spec.ts:74:7 › vue2 › should exact match by props
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:55:7 › cli codegen › should ignore programmatic events
⚠️ [webkit] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [webkit] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:105:7 › cli codegen › should make a positioned click on a canvas
⚠️ [webkit] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [webkit] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:75:7 › cli codegen › should click after same-document navigation
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:501:7 › cli codegen › should check with keyboard
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:584:7 › cli codegen › should select with size attribute
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit] › library/role-utils.spec.ts:37:7 › wpt accname #1
⚠️ [webkit] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page/page-drag.spec.ts:337:3 › should work if not doing a drag
⚠️ [webkit] › library/snapshotter.spec.ts:173:3 › snapshots › should capture iframe
⚠️ [webkit] › library/trace-viewer.spec.ts:979:1 › should ignore 304 responses
⚠️ [webkit] › library/tracing.spec.ts:521:5 › should export trace concurrently to second navigation
⚠️ [webkit] › page/page-history.spec.ts:140:3 › page.reload should not resolve with same-document navigation

172664 passed, 7685 skipped, 5 did not run
✔️✔️✔️

Merge workflow run.

[jtbandes]

Thank you for fixing this! Is there any estimate on when it might be released in a new playwright version?

[mxschmitt]

Thank you for fixing this! Is there any estimate on when it might be released in a new playwright version?

In 1.41 in around a week or in @next NPM tag as of today.

[gre]

@mxschmitt any news on this 1.41 release? thanks

[mxschmitt]

Probably in 1-2 weeks. In the meantime we recommend @next.

[gre]

thanks @mxschmitt
the problem we are experiencing is that we also depends on allure-playwright, so we can't afford to depend on @next because the lib dups it would start to create. so we are eager to have this eventually published. (otherwise we may have to fork the lib temporarily i guess)

[mxschmitt]

thanks @mxschmitt

the problem we are experiencing is that we also depends on allure-playwright, so we can't afford to depend on @next because the lib dups it would start to create. so we are eager to have this eventually published. (otherwise we may have to fork the lib temporarily i guess)

This should be already published in 1.41, could you try that?