Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Electron 28 #5823

Merged
merged 1 commit into from
Feb 2, 2024
Merged

chore: update Electron 28 #5823

merged 1 commit into from
Feb 2, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented Jan 2, 2024

📝 Description

Maintenance update of Electron on LLD.

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 2:16pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 2:16pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 2:16pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 2:16pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 2:16pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 2, 2024
@gre gre force-pushed the support/node-20 branch from 28b71a4 to d776f10 Compare January 4, 2024 10:50
@gre gre force-pushed the support/electron-28 branch from 340d9ac to 9b64e8f Compare January 4, 2024 10:50
Base automatically changed from support/node-20 to develop January 4, 2024 11:54
@gre gre force-pushed the support/electron-28 branch 5 times, most recently from b64953d to 5137f61 Compare January 8, 2024 14:23
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 8, 2024

Desktop Bundle Checks

Comparing 5c1e5fb against c6ea968.

✅ Previous issues have all been fixed.

Mobile Bundle Checks

Comparing 5c1e5fb against 0fc0718.

✅ Previous issues have all been fixed.

@gre gre force-pushed the support/electron-28 branch from 5137f61 to 90ea1d6 Compare February 2, 2024 13:35
Copy link

socket-security bot commented Feb 2, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@sentry/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@gre
Copy link
Contributor Author

gre commented Feb 2, 2024

@SocketSecurity ignore npm/@sentry/[email protected]

@gre gre force-pushed the support/electron-28 branch from 90ea1d6 to 5c1e5fb Compare February 2, 2024 14:15
@gre gre marked this pull request as ready for review February 2, 2024 14:46
@gre gre requested a review from a team as a code owner February 2, 2024 14:46
@gre
Copy link
Contributor Author

gre commented Feb 2, 2024

@gre

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux
✅ - generate-screenshots-mac
✅ - generate-screenshots-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants