Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update electron before release? #3313

Closed
bugsounet opened this issue Dec 31, 2023 · 4 comments
Closed

update electron before release? #3313

bugsounet opened this issue Dec 31, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@bugsounet
Copy link
Contributor

Hi, I just see that electron v28.1.0 release
We are again in v27.2.0 before MM² v2.26.0 release

maybe we can update it ?
@khassel
Copy link
Collaborator

khassel commented Dec 31, 2023

I was waiting for a new playwright release before updating to v28 because our electron tests will fail with current playwright and electron v28

@bugsounet
Copy link
Contributor Author

Ah, ok, I don't think to this

@khassel
Copy link
Collaborator

khassel commented Dec 31, 2023

so for documentation:

PR is merged but still no new release ...

@khassel khassel mentioned this issue Jan 1, 2024
Closed
@khassel khassel added the dependencies Pull requests that update a dependency file label Jan 1, 2024
@khassel
Copy link
Collaborator

khassel commented Jan 16, 2024

develop branch is now upgraded to electron v28 with #3357

@khassel khassel closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khassel @bugsounet