Introduce reused_buffer_index_per_stream in allocation planner which will be reset after computing the reuse buffer for each stream #19515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime into leca/experiment
jslhcl
changed the title
|
Thanks for this ! Do you know if it works when reverting this change? https://github.com/microsoft/onnxruntime/pull/19481/files If it does, we don't need to disable the streams on the DML EP anymore and can revert it. |
Yes it works. I've tested it in v1.17 without your PR. I will revert your PR once this PR is in |
souptc
previously approved these changes
Feb 21, 2024
PatriceVignola
previously approved these changes
Feb 21, 2024
|
/azp run Python format |
|
No pipelines are associated with this pull request. |
PatriceVignola
approved these changes
Feb 22, 2024
tianleiwu
pushed a commit
that referenced
this pull request
Apr 3, 2024
…will be reset after computing the reuse buffer for each stream (#19515) ### Description <!-- Describe your changes. --> Introduce reused_buffer_index_per_stream in allocation planner which will be reset after computing the reuse buffer for each stream. So if a NodeArg is an input of several Ops across different streams and reuses other NodeArg, the reused NodeArg won't be involved when computing the second stream's reuse plan. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> This is to fix #19480, which is a crash for the scenario mentioned above. --------- Co-authored-by: Lei Cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce reused_buffer_index_per_stream in allocation planner which will be reset after computing the reuse buffer for each stream. So if a NodeArg is an input of several Ops across different streams and reuses other NodeArg, the reused NodeArg won't be involved when computing the second stream's reuse plan.
Motivation and Context
This is to fix #19480, which is a crash for the scenario mentioned above.