-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple tests fail on Windows due to ORT_ENABLE_STREAM
define logic error
#20180
Comments
This looks suspicious...both CUDA and ROCm EPs assume streams are always supported...which is a false assumption given the cmake logic above. If cmake logic is correct, then probably an Or, perhaps the cmake logic is wrong and onnxruntime/onnxruntime/core/providers/cuda/cuda_execution_provider.cc Lines 150 to 161 in 8f5c79c
onnxruntime/onnxruntime/core/providers/rocm/rocm_execution_provider.cc Lines 145 to 156 in 8f5c79c
|
Idea 1 failed. I added an #ifdef ORT_ENABLE_STREAM in the CUDA and ROCm ep's to toggle true/false in those constructions. CUDA and TensorRT eps failed constantly in tests. Lots of SEH exceptions
|
Could you try change
to
You can cherry-pick this commit |
@tianleiwu I applied the same PRs to v1.17.1 and all tests pass except for one To troubleshoot further, I manually ran that single test. The test passed.
In VSCode MSVC debugger...the tests pass. 🤔 Same exe, args, etc.
|
@yuslepukhin, the two CUDA (on windows) tests immediately above fail, but if only one test is run it passes. |
### Description Bring the fix for DML to 1.17.3 to resolve an issue #20180 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: cao lei <[email protected]> Co-authored-by: Lei Cao <[email protected]>
This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details. |
ping. keep alive. This issue is still relevant and has PRs pending as a fix. |
I got a similar problem (Ubuntu 24.04 + RTX 3090) [ RUN ] CApiTest.custom_op_set_input_memory_type unknown file: Failure [ FAILED ] CApiTest.custom_op_set_input_memory_type (11 ms) |
Describe the issue
v1.17.1 Windows, with build.bat for build + test, multiple tests fail with
that error is a static ORT_THROW at line 61
onnxruntime/onnxruntime/core/framework/allocator_utils.cc
Lines 51 to 62 in 8f5c79c
Is above code correct? When
ORT_ENABLE_STREAM
is not defined (such as my build.bat options), then should the code calling CreateAllocator(info) not setuse_stream_aware_arena = true
?Is it a logic error in setting up the cmake defines which cascade to compiler defs?
onnxruntime/cmake/adjust_global_compile_flags.cmake
Lines 95 to 103 in 8f5c79c
Urgency
No response
Target platform
Windows
Build script
Error / output
The standard ORT tests are failing. Several. Here are a few
Visual Studio Version
VS2022 v17.9.5
GCC / Compiler Version
No response
The text was updated successfully, but these errors were encountered: