TabView TabGeometry Animation Loop & Under Tab Line Fix #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kmahone
reviewed
Apr 24, 2023
| Visibility="Collapsed" | ||
| Data="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TabViewTemplateSettings.TabGeometry}" /> | ||
|
|
||
| <Canvas> |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bkudiess
pushed a commit
that referenced
this pull request
May 1, 2023
* wrap tabGeometry in Canvas * clean up * add comment (cherry picked from commit 5f52761)
DHowett
pushed a commit
to microsoft/terminal
that referenced
this pull request
May 10, 2023
Reverts #15164, because that's fixed upstream now. Closes #15139. Reverts #15178, but also closes #15121, because that's fixed upstream. see also: * microsoft/microsoft-ui-xaml#8430 * microsoft/microsoft-ui-xaml#8420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When changing TabWidthMode from Equal to SizeToContent, the
1 / ScaleFactoradjustment was causing the TabGeometry to be slightly smaller than its parent LayoutRoot, causing a continuous loop ofOnSizeChanged()/UpdateTabGeometry()calls.Solution:
SelectedBackgroundPathis now wrapped in aCanvasas it does not take up space in the xaml layout. This prevents the infinite loop where the children and parent are dependent on one another for sizing, and prevents regression from these bug fixes: #6954 and #7174I've also updated the Path geometry and removed the 1p adjustment to remove the line between the tabs.
Motivation and Context
Fixes internal bug 44190129 and 40692364
How Has This Been Tested?
Manual verification.
Screenshots (if appropriate):